Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix StackBlitz examples by embedding snippets.js when needed #36352
Fix StackBlitz examples by embedding snippets.js when needed #36352
Changes from all commits
81c0e4d
9fe8be2
1b45dcc
8ec899f
634a6f2
f7837ff
e2c41e3
ab68873
ec79b13
cda3087
c7f240c
4c657cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it ok just use
javascript
template?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used the appropriate template in function of the context but
javascript
would work in both cases yes if we want to simplify. But in this case we would need to create an emptyindex.js
file. The advantage with thehtml
template is that this extra emptyindex.js
file isn't mandatory.However in https://developer.stackblitz.com/docs/platform/javascript-sdk/#sdkopenprojectproject-opts I don't see any
tags
options. Sincehtml
(as template) is not mentioned neither maybe I don't have the latest doc reference 🤷There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may (at least for start) leave it with javascript template, and include
examples.js
by defaultThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the exercise in this PR to include
js_snippet="true"
only when needed in{{< example >}}
. Only few examples really need ajavascript
template just to show the impact.