Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5/docs: reintroduce outline for docs code samples, buttons when :not(:focus-visible) #36507

Merged
merged 3 commits into from Sep 1, 2022
Merged

v5/docs: reintroduce outline for docs code samples, buttons when :not(:focus-visible) #36507

merged 3 commits into from Sep 1, 2022

Commits on Sep 1, 2022

  1. Remove outline suppression for focused <pre> 

    Sighted keyboard users rely on knowing where their focus is. If the `<pre>` receives focus (so that it can be scrolled by keyboard users, for instance) then it's essential that they know this is the case
    @patrickhlauke @mdo
    patrickhlauke authored and mdo committed Sep 1, 2022
    Copy the full SHA
    d1b7e38 View commit details
    Browse the repository at this point in the history

  2. Only suppress outline for buttons when :not(:focus-visible)

    @patrickhlauke @mdo
    patrickhlauke authored and mdo committed Sep 1, 2022
    Copy the full SHA
    8f67bcf View commit details
    Browse the repository at this point in the history

  3. Add right-hand margin to pre 

    avoids having the focus outline awkwardly clipped by the copy button
    @patrickhlauke @mdo
    patrickhlauke authored and mdo committed Sep 1, 2022
    Copy the full SHA
    7765c1e View commit details
    Browse the repository at this point in the history