New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix+example #36585
Fix+example #36585
Conversation
e55d035
to
5201fc0
Compare
Sorry, but what's the need for a new file? |
I suppose just for checking, but I was wondering the same. @louismaximepiton before I try to dig in this solution, have you seen the two failing tests? Both fail to recognize empty string as false. (probably caused , because of the removal of boolean casting) and both of |
Sorry, I was off for few days. Yeah, the new files are my working example, they shouldn't be merged at all, I'll remove them with the next update of the PR. I'll have a look at these examples and try to fix them all this afternoon. |
5201fc0
to
b888ccb
Compare
1e54c0e
to
8e3b8f7
Compare
@louismaximepiton please, make a rebase (we merged #35679), and reopen on main branch. Many, many thanks in advance 😃 |
Hi GeoSot, I made the rebase but I can't change the base branch of this PR. Is there any way that someone could reopen it for me ? Or I'll open a new one if not possible. |
Header.js and index.html shouldn't be merged but this is for a working tooltip example.