Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix+example #36585

Conversation

louismaximepiton
Copy link
Member

Header.js and index.html shouldn't be merged but this is for a working tooltip example.

@louismaximepiton louismaximepiton force-pushed the force-tooltip-to-refresh-content-on-each-show-action-lmp-fix branch from e55d035 to 5201fc0 Compare June 15, 2022 15:13
@XhmikosR
Copy link
Member

Sorry, but what's the need for a new file?

@XhmikosR XhmikosR marked this pull request as draft June 15, 2022 20:10
@GeoSot
Copy link
Member

GeoSot commented Jun 15, 2022

Sorry, but what's the need for a new file?

I suppose just for checking, but I was wondering the same.

@louismaximepiton before I try to dig in this solution, have you seen the two failing tests? Both fail to recognize empty string as false. (probably caused , because of the removal of boolean casting)

and both of _isWithContent now are resolved as it is. In case of a function (especially in the rare case it returns null), I guess it will fail again

@louismaximepiton
Copy link
Member Author

Sorry, I was off for few days. Yeah, the new files are my working example, they shouldn't be merged at all, I'll remove them with the next update of the PR.

I'll have a look at these examples and try to fix them all this afternoon.

@louismaximepiton louismaximepiton force-pushed the force-tooltip-to-refresh-content-on-each-show-action-lmp-fix branch from 5201fc0 to b888ccb Compare June 21, 2022 14:42
@GeoSot GeoSot force-pushed the gs/force-tooltip-to-refresh-content-on-each-show-action branch 2 times, most recently from 1e54c0e to 8e3b8f7 Compare June 27, 2022 09:44
@GeoSot GeoSot deleted the branch twbs:gs/force-tooltip-to-refresh-content-on-each-show-action June 27, 2022 09:58
@GeoSot GeoSot closed this Jun 27, 2022
@GeoSot
Copy link
Member

GeoSot commented Jun 27, 2022

@louismaximepiton please, make a rebase (we merged #35679), and reopen on main branch.

Many, many thanks in advance 😃

@louismaximepiton
Copy link
Member Author

louismaximepiton commented Jun 27, 2022

Hi GeoSot, I made the rebase but I can't change the base branch of this PR. Is there any way that someone could reopen it for me ? Or I'll open a new one if not possible.

@louismaximepiton louismaximepiton mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants