Allow floating label to take full width when floating (scaled down) #36703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the floating label to expand its width as it's scaled down because the `width: 100%` as defined in twbs#36327 will no longer be correct.
|
Do you have a live demo of the problem you're running into? |
|
I should be able to put something together, but a bit busy at the moment. |
|
Closing this out for now as it's a little stale until we see a demo of the issue you're running into :). Happy to re-open when this is ready to go or review a new PR :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the floating label to expand its width as it's scaled down because the
width: 100%as defined in #36327 will no longer be correct.I'm not sure about the process for adding new variables and if this is acceptable. I also realize that
/outside ofcalc(...)is deprecated but I don't see any uses of@use 'sass:math'in the codebase andcalc(...)was complaining it was not allowed when runningnpm run testand I was not sure if I should modify an allowlist or what would be preferred here.