Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework button focus/active styling, with extra changes for checks/radios #37026

Merged
merged 10 commits into from Sep 4, 2022
Merged

Rework button focus/active styling, with extra changes for checks/radios #37026

merged 10 commits into from Sep 4, 2022

Commits on Aug 25, 2022

  1. Replace :focus styles with :focus-visible

    @patrickhlauke
    patrickhlauke committed Aug 25, 2022
    Copy the full SHA
    1ad1002 View commit details
    Browse the repository at this point in the history

  2. Remove :active / .active styles

    @patrickhlauke
    patrickhlauke committed Aug 25, 2022
    Copy the full SHA
    b654ef1 View commit details
    Browse the repository at this point in the history

  3. Don't apply :hover styles for .btn that follows a .btn-check 

    This removes a large part of the visual confusion of button checks/radios - that you currently have to move your mouse away from them to see what they actually changed to (checked or unchecked)
    @patrickhlauke
    patrickhlauke committed Aug 25, 2022
    Copy the full SHA
    a98f616 View commit details
    Browse the repository at this point in the history

  4. Reintroduce :active, but *not* for button checks/radios

    @patrickhlauke
    patrickhlauke committed Aug 25, 2022
    Copy the full SHA
    6ea6edd View commit details
    Browse the repository at this point in the history

  5. Sort focus styling specifically for button checks/radios 

    don't change background on focus, just give it the border/outline. again, avoids confusion whether something is checked or not while focused
    @patrickhlauke
    patrickhlauke committed Aug 25, 2022
    Copy the full SHA
    c942ef1 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Merge branch 'main' into patrickhlauke-check-radio-buttons-focus-visible

    @patrickhlauke
    patrickhlauke committed Sep 1, 2022
    Copy the full SHA
    136ef18 View commit details
    Browse the repository at this point in the history

  2. Re-add outline:0 which was lost when resolving last merge conflict

    @patrickhlauke
    patrickhlauke committed Sep 1, 2022
    Copy the full SHA
    5685463 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into patrickhlauke-check-radio-buttons-focus-visible

    @patrickhlauke
    patrickhlauke committed Sep 1, 2022
    Copy the full SHA
    d747558 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into patrickhlauke-check-radio-buttons-focus-visible

    @mdo
    mdo committed Sep 1, 2022
    Copy the full SHA
    5aab767 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Merge branch 'main' into patrickhlauke-check-radio-buttons-focus-visible

    @mdo
    mdo committed Sep 4, 2022
    Copy the full SHA
    deae030 View commit details
    Browse the repository at this point in the history