Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Manage the dark offcanvas slightly differently #37056

Merged
merged 1 commit into from Sep 1, 2022
Merged

Docs: Manage the dark offcanvas slightly differently #37056

merged 1 commit into from Sep 1, 2022

Conversation

louismaximepiton
Copy link
Member

Set the dark paragraph as a <h2> to be more consistent with dropdowns, Close button and Carousel.

julien-deramond
julien-deramond approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me except if someone has a reason to think that it must stays in the middle of 'Examples' in terms of readability (not too far from the light version).

@mdo mdo merged commit 1531867 into twbs:main Sep 1, 2022
@louismaximepiton louismaximepiton deleted the main-lmp-dark-doc-fix branch September 2, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
docs v5
Projects
No open projects
v5.2.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louismaximepiton @mdo @julien-deramond