Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modal event listeners #37128

Merged
merged 9 commits into from Sep 15, 2022
Merged

Fix modal event listeners #37128

merged 9 commits into from Sep 15, 2022

Commits on Sep 12, 2022

  1. Fix modal event listeners (#37126) 

    Add a check to ensure that the element that triggered the event is still present in the DOM.
    Jérémie Broutier committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    b483cfd View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. Merge branch 'main' into fix-modal-event-listeners

    Jérémie Broutier committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    90d2b80 View commit details
    Browse the repository at this point in the history

  2. Add unit test.

    Jérémie Broutier committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    df21232 View commit details
    Browse the repository at this point in the history

  3. Check both events instead of just one.

    Jérémie Broutier committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    39e349d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix-modal-event-listeners

    Jérémie Broutier committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    95a6917 View commit details
    Browse the repository at this point in the history

  5. lint

    @GeoSot
    GeoSot committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    40250e6 View commit details
    Browse the repository at this point in the history

  6. Use strict comparison instead of contains.

    Jérémie Broutier committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    f3f89ee View commit details
    Browse the repository at this point in the history

  7. remove redundant check

    @GeoSot
    GeoSot committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    ece7f44 View commit details
    Browse the repository at this point in the history

  8. add comment

    @GeoSot
    GeoSot committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    41f664f View commit details
    Browse the repository at this point in the history