Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use child combinators to avoid inheriting parent accordion's flush styles #37508

Merged
merged 10 commits into from
Nov 17, 2023

Conversation

nkdas91
Copy link
Contributor

@nkdas91 nkdas91 commented Nov 17, 2022

Description

Use child combinators to avoid inheriting parent accordion's flush styles

Motivation & Context

Fixes #37455

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

No changes in documentation
https://deploy-preview-37508--twbs-bootstrap.netlify.app/docs/5.3/components/accordion/

Code Pen
https://codepen.io/nkdas91/pen/VwdMXVm

Related issues

#37455

Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me if you agree @julien-deramond

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found no regression by testing different nesting and regular use cases. LGTM! Thanks for the PR!

@julien-deramond julien-deramond merged commit ee88ae6 into twbs:main Nov 17, 2023
14 checks passed
@nkdas91 nkdas91 deleted the accordion branch November 17, 2023 14:01
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
…wbs#37508)

Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
Co-authored-by: Julien Déramond <juderamond@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested accordion inherits parent's flush styling
4 participants