Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix live toast demo #37590

Merged
merged 7 commits into from Jan 3, 2023
Merged

fix live toast demo #37590

merged 7 commits into from Jan 3, 2023

Conversation

AucT
Copy link
Contributor

@AucT AucT commented Dec 6, 2022 •
edited by XhmikosR

Description

Fixed your example

Motivation & Context

Change is required for toast work without glitches.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fixes #33906

@julien-deramond

This comment was marked as resolved.

Sign in to view
@AucT AucT requested a review from a team as a code owner December 6, 2022 09:21
@AucT
Copy link
Contributor Author

AucT commented Dec 6, 2022

I'm very noob to this github merging and forking stuff.
So if something is wrong - cancel pull and make as it should be.

@julien-deramond
Copy link
Member

Yep don't worry. We'll take a look at your PR asap. Thanks for opening it btw.

mdo
mdo approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed in the demos that this is better, thanks!

@XhmikosR
Copy link
Member

This needs a rebase, and I'd like to hear @GeoSot's opinion too.

@XhmikosR XhmikosR requested a review from GeoSot December 26, 2022 20:12
@mdo mdo merged commit 19d547b into twbs:main Jan 3, 2023
@AucT AucT deleted the patch-1 branch January 3, 2023 11:27
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR left review comments

@GeoSot GeoSot GeoSot left review comments

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
awaiting-reply docs js v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast-timing is very inconsistent.
5 participants
@AucT @julien-deramond @XhmikosR @mdo @GeoSot