Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance dark mode text contrast #38530

Closed
wants to merge 2 commits into from
Closed

Conversation

ruiarii
Copy link

@ruiarii ruiarii commented Apr 28, 2023

Description

I changed the $body-emphasis-color-dark variable to $white, it will make the dark mode text appear white instead of the default $gray-500 so there is a better contrast in the text appearance when dark mode is enabled

Motivation & Context

This will improve the contrast between the text and the background, making it easier to read.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

#38525

@ruiarii ruiarii requested a review from a team as a code owner April 28, 2023 20:11
@mdo
Copy link
Member

mdo commented Apr 30, 2023

We'll be holding off on making this kind of change for now.

@mdo mdo closed this Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants