Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#39150 : fix incorrect borders in list-group-horizontal #39193

Closed
wants to merge 1 commit into from

Conversation

Luciferxgkp
Copy link

@Luciferxgkp Luciferxgkp commented Sep 16, 2023

Description

Closes #39150

I Have tried to solve the issue of #39150 but i don't know how to test the css that i changes locally.

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@julien-deramond
Copy link
Member

Thanks for creating this PR @Luciferxgkp
Sorry for delay of the review.
I've checked the suggested modification but the rendering doesn't work with the use case from the CodePen in the description:

<!-- Follow these instructions, please! -->
<div class="container py-5">
  <!-- a card with a link list group -->
  <div class="card" style="width: 18rem;">
    <div class="card-header">
      Featured
    </div>

    <div class="list-group list-group-flush list-group-horizontal">
      <a href="#" class="list-group-item list-group-item-action">Certificates</a>
      <a href="#" class="list-group-item list-group-item-action">Products</a>
      <a href="#" class="list-group-item list-group-item-action">AHA</a>
    </div>
  </div>

  <hr class="border-0">

  <div class="list-group list-group-flush list-group-horizontal">
    <a href="#" class="list-group-item list-group-item-action">Certificates</a>
    <a href="#" class="list-group-item list-group-item-action">Products</a>
    <a href="#" class="list-group-item list-group-item-action">AHA</a>
  </div>

Here's the rendering with the PR:
Screenshot 2023-11-13 at 17 39 51

I will close this PR for now. Feel free to open a new one if you managed to find another solution.

but i don't know how to test the css that i changes locally.

Basically, you have to clone the project, run npm i and then npm run start. And go for example to http://localhost:9001/docs/5.3/components/list-group/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect borders with .list-group-flush.list-group-horizontal
2 participants