Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: add expanded accordion explanation #39304

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Oct 16, 2023

Description

This PR suggests fixing the accordion's documentation about how to render it when expanded.

The original sentence was in fact not correct from the beginning as there was no .open class used for the accordions. The correct class is .show, but is not enough to make the accordion expand. The .collapsed class needs to be removed and the aria-expanded attribute needs to be set to true.

This description has been updated to reflect the changes and moved to the "Example" section.

Feel free to enhance this fix directly if you have any suggestions.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39303

@julien-deramond julien-deramond marked this pull request as ready for review October 16, 2023 19:43
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
@julien-deramond julien-deramond merged commit dac6007 into main Oct 23, 2023
22 checks passed
@julien-deramond julien-deramond deleted the main-jd-improve-expanded-accordion-doc branch October 23, 2023 17:25
priyashpatil pushed a commit to priyashpatil/bootstrap that referenced this pull request Nov 8, 2023
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect documentation
2 participants