Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color schemes description in Sass customization documentation #39417

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Nov 17, 2023

Description

This PR fixes the description of the "Color schemes" contained in "Customize > Sass" documentation page.
As mentioned in the issue's discussion, Media Queries Level 5 spec mentions that the only values of prefers-color-scheme are light and dark. So talking about custom values is wrong.

I chose to avoid mentioning the fact that the spec says that the values might be expanded in the future:

The values for this feature might be expanded in the future (to express a more active preference for light color schemes, or preferences for other types of color schemes like "sepia").

Type of changes

  • Documentation bug fix

Checklist

  • I have read the contributing guidelines
  • (N/A) My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • (N/A) All new and existing tests passed

Live previews

Related issues

Closes #39410

@julien-deramond julien-deramond merged commit e4f0d61 into main Nov 18, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-color-scheme-doc branch November 18, 2023 08:52
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass Color Scheme mixin incorrectly claims it supports custom schemes
2 participants