Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add shift-color() usage example in sass customization page #39435

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Nov 24, 2023

Description

This PR suggests adding a new .custom-element-3 example in our Customize > Sass > Colors page to show how to use shift-color().

When .custom-element-3 is applied to a <div>, here is the corresponding rendering:

Screenshot 2023-11-24 at 17 45 15

Motivation & Context

This is an enhancement that could be useful to folks when they are using this Sass function to show that the weight must be set in percentage too.

Type of changes

  • Docs enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39432

@julien-deramond julien-deramond force-pushed the main-jd-improve-customize-sass-colors-doc branch from 42eb97e to 45408e5 Compare November 24, 2023 16:51
@julien-deramond julien-deramond marked this pull request as ready for review November 24, 2023 16:52
@julien-deramond julien-deramond merged commit f1cd118 into main Dec 12, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-improve-customize-sass-colors-doc branch December 12, 2023 07:08
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning (passing a number without unit)
3 participants