Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: enhance .card-img-* description #39458

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 2, 2023

Description

As mentioned in #39456, the description for ".card-img-top" states that it places an image on the top of the card. There is no description of what "card-img-bottom" does.

This PR suggests a new description that explains what both classes actually do.

Type of changes

  • Doc enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fixes #39456

@julien-deramond julien-deramond merged commit 4352422 into main Dec 10, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-card-img-top-doc branch December 10, 2023 07:23
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Documentation on "card-img-top" appears to incorrect for Version 5.3
3 participants