Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating labels: Fix max-width and background-color #39720

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Floating labels: Fix max-width and background-color #39720

wants to merge 2 commits into from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Feb 29, 2024 •
edited

Description

Add a max-width to label inside Floating labels. Reverting and upgrading a change inside #38313.

Motivation & Context

Issue described in #39080.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39080.
Might supersede #39480.

@louismaximepiton louismaximepiton linked an issue Feb 29, 2024 that may be closed by this pull request
On form floating inputs, the labels are not truncated anymore but they go outside the input box instead #39080
Open
3 tasks
@louismaximepiton louismaximepiton requested a review from a team as a code owner February 29, 2024 09:35
@louismaximepiton louismaximepiton changed the title Floating labels: Fix max-width Floating labels: Fix max-width and background-color Feb 29, 2024
mdo
mdo approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@theodorejb theodorejb mentioned this pull request Mar 18, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On form floating inputs, the labels are not truncated anymore but they go outside the input box instead
2 participants
@louismaximepiton @mdo