Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a new partial for responsive images and use imageConfig #39779

Merged
merged 6 commits into from
Apr 1, 2024
Merged

docs: add a new partial for responsive images and use imageConfig #39779

merged 6 commits into from
Apr 1, 2024

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 12, 2024 •
edited

This way the dimensions are not hardcoded

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR added the docs label Mar 12, 2024
@XhmikosR XhmikosR force-pushed the xmr/docs-imgconfig branch 2 times, most recently from 4dff889 to f3e40fd Compare March 13, 2024 06:09
@XhmikosR XhmikosR changed the title docs: switch to imageConfig docs: add a new partial for responsive images and use imageConfig Mar 13, 2024
@XhmikosR XhmikosR marked this pull request as ready for review March 19, 2024 09:34
@XhmikosR XhmikosR mentioned this pull request Mar 22, 2024
Merged
11 tasks
@XhmikosR XhmikosR merged commit 4093ed3 into main Apr 1, 2024
14 checks passed
@XhmikosR XhmikosR deleted the xmr/docs-imgconfig branch April 1, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs
Projects
v5.3.4
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@XhmikosR