Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example of background color when items are clicked #39831

Closed
wants to merge 2 commits into from
Closed

Add an example of background color when items are clicked #39831

wants to merge 2 commits into from

Conversation

ZhangChengLin
Copy link
Contributor

@ZhangChengLin ZhangChengLin commented Mar 25, 2024 •
edited

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@ZhangChengLin ZhangChengLin marked this pull request as ready for review March 27, 2024 02:02
@mdo
Copy link
Member

mdo commented Apr 15, 2024

Thanks, but we'll pass on this—the mixing of components like that gets messy real quickly.

@mdo mdo closed this Apr 15, 2024
@ZhangChengLin
Copy link
Contributor Author

the mixing of components like that gets messy real quickly.

The common goal is to make them better and better for the long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZhangChengLin @mdo