-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PostCSS-RTLCSS approach to the documentation #39863
Add PostCSS-RTLCSS approach to the documentation #39863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @elchininet!
The explanation looks good to me and has the right level of information; not too much, but enough to understand how PostCSS RTLCSS could be embedded in one's project.
I'll let a native English speaker double-check the wording and also pinging @ffoodd for feedback (does it look OK to you too?).
Seems great! Thanks for the contribution. The third point makes me wonder: could we move This shouldn't have any impact on our side. |
Hi @ffoodd,
What do you mean moving them to their block version? I have plans of making this transparent for clients. As the intention of the RTLCSS directive is the same (do not create an RTL counterpart in the new stylesheet), what I want to achieve is that if someone uses a But just let me know if you think that I should change that point or remove something from it at the moment. Regards |
My point is that moving directives as recommendend in your third point can be easily achieved un Bootstrap. If we do it, would it ease your plugin usage? |
Ah, got it. I would not change anything in the Bootstrap source code because |
Ah, got it too. Thanks, that's clearer 👌 |
Description
This pull request modifies the LTR and RTL at the same time section of the documentation to explain how to achieve that goal using PostCSS-RTLCSS.
Motivation & Context
Searching topics that included
PostCSS-RTLCSS
on the Internet, I found this StackOverflow question asking how to achieve LTR and RTL in Bootstrap at the same time, and the most voted answer mentionedPostCSS-RTLCSS
as a better alternative to the instructions given in the documentation.As I am the manintainer of the
PostCSS-RTLCSS
plugin, I opened this discussion explaining the benefits of achievingLTR and RTL at the same time
usingpostcss-rtlcss
instead. Then as an outcome of the discussion, it was agreed to mention the plugin in the respective section in the documentation.Type of changes
Checklist
npm run lint
)Live previews
Related issues
https://github.com/orgs/twbs/discussions/39726