Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Form Layout depending on screen size #39874

Conversation

JasvinderSingh0309
Copy link

@JasvinderSingh0309 JasvinderSingh0309 commented Apr 6, 2024

Description

Added a col-md-form-label class with breakpoint. Acts as form-label in small screens and col-form-label in larger screens. Has padding top and bottom in large screens and in small screens those padding is removed and margin bottom is added.

Motivation & Context

while using the col-form-label class instead of form-label causes and extra padding on the top.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@JasvinderSingh0309 JasvinderSingh0309 requested a review from a team as a code owner April 6, 2024 11:15
@julien-deramond julien-deramond marked this pull request as draft April 6, 2024 11:18
@JasvinderSingh0309 JasvinderSingh0309 marked this pull request as ready for review April 6, 2024 11:25
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR @JasvinderSingh0309
I'm not sure if this is a feature that we would integrate by default in Bootstrap.
Anyway, this PR is incomplete:

  • Lint issues
  • @media shouldn't be used as is; the rest of the codebase is using @include media-* mixins.
  • This new feature is not documented
  • If such a feature would be implemented, it couldn't be just for the md breakpoint. It should work for all breakpoints.

@JasvinderSingh0309
Copy link
Author

Thank you for the feedback on my pull request. As a beginner, I'm keen to improve. Could you share more detailed feedback? It will help me focus on areas for future contributions. Thanks for your time and guidance.

@julien-deramond
Copy link
Member

Unfortunately, I'm working on Bootstrap on my spare time, and can't use this time to onboard someone on the technical aspects of the codebase, even if I would love it.

I will close this PR that is missing at least what's described in #39874 (review).

I would advise you to start by creating a new issue or a new GitHub discussion first explaining why this could be useful for the project.
By doing so, the idea can be discussed with the maintainers, and the development can start at the right time.

Even if your PR was perfect, we should wait until we're ready to start a new minor version (v5.4 for example) and couldn't (wouldn't have the time) to review it before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants