Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change vite config path import #332

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Nov 15, 2023

Description

This PR changes the way we import resolve from path in the Vite config.
This change is suggested to be consistent with the way Vite project imports itself resolve in the vite.config.ts file in its own documentation (e.g. https://vitejs.dev/guide/build.html#multi-page-app).

It doesn't change anything in the way this example works. You can still run it locally this way:

  • npm run start
  • npm run build

Checklist

@julien-deramond julien-deramond added the enhancement New feature or request label Nov 15, 2023
@julien-deramond julien-deramond merged commit 4cf084d into main Nov 18, 2023
12 checks passed
@julien-deramond julien-deramond deleted the main-jd-change-vite-config-path-import branch November 18, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants