Update SVG build script to set custom dimensions #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the fixed width and height override from the build script and instead detects the viewBox values and sets the width and height from there. The goal of this is allow for different aspect ratios in icons. My gut says everything should be 16px tall to address vertical align issues, but then have some variable width. To start, this will be for select icons (possibly the new Bootstrap logo and our upcoming badge icons), and then potentially redoing artboards in Figma for super narrow icons so they only take up the required space. That'll come later I think though.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the fixed width and height override from the build script and instead detects the
viewBoxvalues and sets thewidthandheightfrom there. The goal of this is allow for different aspect ratios in icons. My gut says everything should be16pxtall to address vertical align issues, but then have some variable width.To start, this will be for select icons (possibly the new Bootstrap logo and our upcoming badge icons), and then potentially redoing artboards in Figma for super narrow icons so they only take up the required space. That'll come later I think though.