Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SVG build script to set custom dimensions #305

Merged
merged 4 commits into from Jun 23, 2020
Merged

Update SVG build script to set custom dimensions #305

merged 4 commits into from Jun 23, 2020

Commits on Jun 23, 2020

  1. Update SVG build script to set custom dimensions 

    This removes the fixed width and height override from the build script and instead detects the viewBox values and sets the width and height from there. The goal of this is allow for different aspect ratios in icons. My gut says everything should be 16px tall to address vertical align issues, but then have some variable width.

To start, this will be for select icons (possibly the new Bootstrap logo and our upcoming badge icons), and then potentially redoing artboards in Figma for super narrow icons so they only take up the required space. That'll come later I think though.
    @mdo
    mdo committed Jun 23, 2020
    Copy the full SHA
    e8faf50 View commit details
    Browse the repository at this point in the history

  2. Re-process icons

    @mdo
    mdo committed Jun 23, 2020
    Copy the full SHA
    ae2b541 View commit details
    Browse the repository at this point in the history

  3. Re-run sprite

    @mdo
    mdo committed Jun 23, 2020
    Copy the full SHA
    b30306d View commit details
    Browse the repository at this point in the history

  4. Update script to account for upcoming font-family generation

    @mdo
    mdo committed Jun 23, 2020
    Copy the full SHA
    3cfd47a View commit details
    Browse the repository at this point in the history