Add --venv option to CLI
#219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherland
force-pushed
the
jherland/look-at-other-venv
branch
from
6ba869e
to
e75553d
Compare
jherland
force-pushed
the
jherland/venv-setting
branch
from
eda14a1
to
866a317
Compare
|
🎉 All dependencies have been resolved ! |
jherland
force-pushed
the
jherland/venv-setting
branch
from
866a317
to
d0cc87d
Compare
Nour-Mws
reviewed
Mar 14, 2023
4 tasks
One step closer to exposing the ability to look at other venvs to our end users. Add a couple of tests using this new resolve_dependencies() argument. Also add a fixture for quickly setting up a fake venv (just enough of a directory structure to fool importlib_metadata into finding packages and associated import names). This fixture could become useful in many of our other tests in order to isolate our tests from the current venv.
jherland
force-pushed
the
jherland/venv-setting
branch
from
0aaf6e0
to
6aef460
Compare
Hook it up to the venv_path argument to resolve_depenedencies(), to allow the user to control which venv FawltyDeps uses to map dependencies into import names. For now we only accept a single venv dir here, but this might change in the near future. TODO: Write tests to verify that setting the command-line/config option has the desired effect.
Until now we've used Experiment.venv_with_fawltydeps() to install FawltyDeps into the experiment's venv before each test run, and uninstall it afterwards. The new --venv flag enables us to instead have FawltyDeps analyze the experiment's venv _without_ first being installed into it. Use the --venv flag, and remove the now-obsolete FawltyDeps installation from the experiment venvs.
jherland
force-pushed
the
jherland/venv-setting
branch
from
6aef460
to
21866ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #215.
packages: Addvenv_pathargument toresolve_dependencies()venvsetting and--venvcommand-line optiontest_real_projects: Use--venvinstead of editable install of FD