Remove pylint #426
Merged
Remove pylint #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jherland
force-pushed
the
jherland/make-ruff-strict
branch
from
98102f3
to
ac3999a
Compare
jherland
force-pushed
the
jherland/remove-pylint
branch
from
1621cb9
to
59de27c
Compare
jherland
force-pushed
the
jherland/make-ruff-strict
branch
from
ac3999a
to
17eae72
Compare
jherland
force-pushed
the
jherland/remove-pylint
branch
from
59de27c
to
251cfba
Compare
mknorps
approved these changes
May 8, 2024
AFAICS, there is no difference in behavior when running `mypy` or `ruff check .` in a Python environment based on v3.7 or one based on v3.12. These tools should behave the same irrespective of the Python version in the surrounding environment. Hence, there is no longer any need to run nox's "lint" session under each of our supported Python versions. This will divide the time spent on linters by 6.
jherland
force-pushed
the
jherland/remove-pylint
branch
from
251cfba
to
1755d63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
pylint, as it has now been fully replaced byruff. The last PR in a series of 3.Commits:
ruffinstead ofpylintnoxfile.py: Removepylintfromlintsessionpylintannotations from source codepyproject.toml: Removepylintfrom our dependencies