Use ruff format instead of black
#427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jherland
force-pushed
the
jherland/remove-pylint
branch
2 times, most recently
from
59de27c
to
251cfba
Compare
jherland
force-pushed
the
jherland/ruff-format-instead-of-black
branch
from
f409601
to
a2c964c
Compare
mknorps
approved these changes
May 10, 2024
jherland
force-pushed
the
jherland/remove-pylint
branch
from
251cfba
to
1755d63
Compare
We have already disabled the line-length warning from `ruff check`, so this directive already have no effect. We're about to replace `black` with `ruff format`, and in order for the latter to behave as similarly to the former as possible, we want to configure both with the same line-length. Both tools default to line- length = 88, so that is what we want to use as well. Simply remove the directive to achieve this.
The checks/formatting being done by isort is already covered by `ruff check .`, so there is no need to run isort separately in our formatting sessions. Note that isort itself remains a main/direct dependency of FawltyDeps itself. This commit only concerns its use as a formatting tool.
jherland
force-pushed
the
jherland/ruff-format-instead-of-black
branch
from
a2c964c
to
fc666fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff comes with a built-in formatter (
ruff format) which serves as a drop-in replacement forblack. The difference in the formatting are minuscule, and can be seen in the second commit in this PR.Also remove
isortas a formatting dependency, sinceruff checkalready performs the same checks.Commits:
line-lengthruff format .noxfile.py: Runruff formatinstead ofblackblackas a dependencyisortas a formatting dependencyruffinstead ofblack+isort