Usage oriented test-suite #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2023 15:07
added 12 commits
March 6, 2023 11:48
- Yes/no validators - A validator that checks the datum type of its continuing output - InlineDatumSpec uses the latter validator - Some simple traces: Paying to wallets and scripts with different datum formats
And some traces, among which some behave curiously
added 6 commits
March 10, 2023 09:32
carlhammann
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Thanks, @gabrielhdt, this is already a big improvement! I left a few comments, but I think we're close to getting this merged.
tests/Cooked/Behaviour/Validators.hs
Outdated
There was a problem hiding this comment.
I really like this module! Can we have a few scripts (and tests) about staking as well?
There was a problem hiding this comment.
Maybe this module should not live in the Behaviour hierarchy. We might want to use these validators also in unit tests for tweaks (if only to have some script to direct paysScripts to).
There was a problem hiding this comment.
I'm not sure we can test anything about staking here, it may be the case that some additional fields in the skeleton are needed
carlhammann
reviewed
Mar 14, 2023
gabrielhdt
force-pushed
the
gh/test-suite-again
branch
from
dd05002
to
aa76840
Compare
Replace walletToScript by walletToScriptHowDatum
- Created a new 'Other' module where to put validators that are not Unit - Moved validators from DoubleSatSpec to the Validators module
Use UTxO when we talk about resulting outputs of a transaction, *submit* a transaction and *produce* an output or UTxO
Co-authored-by: carlhammann <102371507+carlhammann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this all about
This PR provide a test suite designed around nominal use cases of Cooked. It ought to contain
Changes
tests/Cooked/Unittests/Cooked/Behaviour.Cooked.Behaviour.Validatorscontains a collection of validators with unit datum and redeemersCooked.Behaviour.Elementarycontains some standard-ish traces.Questionable behaviours revealed so far
TxSkelRedeemerForScriptwhenTxSkelRedeemerForReferenceScriptyields the following confusing error messageThe problem with validators checking fees
Because the fee of a transaction is available in its context (see the datatype for contexts), one may write validators that succeed upon some condition over the fee. However, because the value of the fee depends on the complexity of the validator, the latter has to be run to compute the former. This leads to a fixpoint algorithm:
Therefore, the validator is run in several contexts which differ at least by their fee value. In particular, validators are always run at least once with$f_0$ so one cannot write a validator that succeeds if and only if the transaction it is run in has fees strictly smaller than $f_0$ .
See issue #341.