Nix/nickel #1067
Draft
Nix/nickel #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francois-caddet
force-pushed
the
nix/nickel
branch
from
103397f
to
4d8fee6
Compare
francois-caddet
force-pushed
the
nix/nickel
branch
from
3cb86c9
to
d86a115
Compare
- parse a let binding of type `let <IDENT> = <LITERAL>; in <IDENT>` - can parse when multiple bindings in the let - for now, concider every let as recursive let.
Have to translate nix let blocks to a nickel destructuring. Because destructuring need a span, this commit make `FileId` required to parse nix files. Also it was a good oportunity to add terms positions to parsed terms.
patterns fields now. tODO: update the pretty printer to print the full pattern an not only the at binding. May be in a extra PR.
Make parsing of `record.${a field expr}` parsable.
It may not be parsed at term level but should not be an issue because it
effectively return a term and if not used at right place, the parser
will return an error anyway.
Co-authored-by: Yann Hamdaoui <yann.hamdaoui@gmail.com>
Add a filter to include `tests/nix/*.nix` files
in Nix `0.625` is not equivalant to `5/8` even if it works in nickel, we prefer to stay correct and compare frac with frac.
At the same time, it clean and simplify some parts of the code
Co-authored-by: Yann Hamdaoui <yann.hamdaoui@tweag.io>
Co-authored-by: Yann Hamdaoui <yann.hamdaoui@tweag.io>
- impl this trait for `rnix` operators and `SyntaxNode` - others code cleaning
now able to evaluate `{...} ? <field_path>`
Identifiers require a position. So, we added it
- complex shadowing - nested record combined with a with - with and recursive record which does not pass for now (check todos in `tests/nix/with.nix`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main branch for the developement of a nix compatibility for nickel.
The idea of this compatibility is to give Nickel the capacity to evaluate Nix expressions.
As first step we will focus on the evaluation of the core language, without standart lib.