Split of Topiary's builtin query files into their own crate #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinvanderVeen
added
the
Pblocked
2 tasks
Xophmeister
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
I really like the idea of enabling language support (or, at least, queries1) behind feature flags. I was a little dubious, at first, about baking the queries into the binary, but it works -- and I guess it's necessary for the feature flags -- so ¯\_(ツ)_/¯
Footnotes
-
I wonder if it would be useful to extend the features to the included grammars, as well? However, this is probably not worthwhile if "languages" are eventually going to be completely decoupled from the library... ↩
Also renames languages to queries because that is arguably what it contains. Also, this aligns more with the internal naming of language/query. (We still need to get rid of "grammar").
ErinvanderVeen
force-pushed
the
topiary-query-files-crate
branch
from
d68c0dd
to
b02bd73
Compare
ErinvanderVeen
force-pushed
the
topiary-query-files-crate
branch
from
9abb560
to
88ec4fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #606.
This PR can only be merged after #583
TODO:
main