fixed Issue #1443 #1444
Merged
fixed Issue #1443 #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also added endpoint |
Harmon758
requested changes
Dec 25, 2020
tweepy/api.py
Outdated
Comment on lines
1037
to
1051
| @property | ||
| def lists_ownerships(self): | ||
| """ :reference: https://developer.twitter.com/en/docs/twitter-api/v1/accounts-and-users/create-manage-lists/api-reference/get-lists-ownerships | ||
| :allowed_param: 'screen_name', 'user_id', | ||
| 'cursor', 'count' | ||
| """ | ||
| return bind_api( | ||
| api=self, | ||
| path='/lists/ownerships.json', | ||
| payload_type='list', payload_list=True, | ||
| allowed_param=['screen_name', 'user_id', | ||
| 'cursor', 'count'], | ||
| require_auth=True | ||
| ) | ||
|
|
There was a problem hiding this comment.
This should be part of a separate pull request, which should also add documentation for the method.
tweepy/api.py
Outdated
Comment on lines
1161
to
1183
| 'cursor' | ||
| 'cursor', 'count' | ||
| """ | ||
| return bind_api( | ||
| api=self, | ||
| path='/lists/members.json', | ||
| payload_type='user', payload_list=True, | ||
| allowed_param=['owner_screen_name', 'slug', 'list_id', 'owner_id', | ||
| 'cursor'] | ||
| 'cursor', 'count'] |
There was a problem hiding this comment.
This should also be part of another separate pull request, which should also add documentation for the new allowed parameter.
tweepy/models.py
Outdated
Comment on lines
200
to
204
| *args, | ||
| **kwargs) | ||
|
|
||
| def lists_ownerships(self, *args, **kwargs): | ||
| return self._api.lists_ownerships(user_id=self.id, |
There was a problem hiding this comment.
This should be part of the separate pull request that adds API.lists_ownerships.
Harmon758
added
the
Need Follow-Up
|
Since this is the last PR I want to include for v3.10, I've gone ahead and removed the extraneous changes myself. |
Harmon758
approved these changes
Dec 26, 2020
Harmon758
removed
the
Need Follow-Up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.