Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Multi-links field] Delete url from list #5117

Closed
Tracked by #3607
thaisguigon opened this issue Apr 23, 2024 · 0 comments · Fixed by #5313
Closed
Tracked by #3607

[Multi-links field] Delete url from list #5117

thaisguigon opened this issue Apr 23, 2024 · 0 comments · Fixed by #5313
Assignees
@thaisguigon
Labels
scope: back+front Issues requiring full-stack knowledge

Comments

@thaisguigon
Copy link
Contributor

thaisguigon commented Apr 23, 2024 •
edited

Context

For this issue:

  • In the Links field cell, when the edit mode drodpown is open, display on link item hover a "Vertical dots" button for each item, except for the primary link.
  • On the "Vertical dots" button click, a dropdown opens with only one option (for now): Delete.
  • On click, the "Delete" option removes the link from the Links field value.
  • For the primary link, display a "Bookmark" icon.

Figma

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=28571-77520&mode=design&t=8H0WXoGxe5R9TkbE-11
@thaisguigon thaisguigon mentioned this issue Apr 23, 2024
Open
@thaisguigon thaisguigon self-assigned this Apr 23, 2024
@thaisguigon thaisguigon added the scope: back+front Issues requiring full-stack knowledge label Apr 23, 2024
thaisguigon added a commit that referenced this issue May 6, 2024
@thaisguigon
feat: remove a link from a Links field
507770b 
Closes #5117
@thaisguigon thaisguigon mentioned this issue May 6, 2024
Merged
thaisguigon added a commit that referenced this issue May 7, 2024
@thaisguigon
feat: remove a link from a Links field
83563b6 
Closes #5117
thaisguigon added a commit that referenced this issue May 8, 2024
@thaisguigon
feat: remove a link from a Links field
2350c4d 
Closes #5117
This was referenced May 13, 2024
Closed
Closed
thaisguigon added a commit that referenced this issue May 15, 2024
@thaisguigon
feat: remove a link from a Links field
404b3f7 
Closes #5117
thaisguigon added a commit that referenced this issue May 17, 2024
@thaisguigon
feat: remove a link from a Links field
a279ada 
Closes #5117
thaisguigon added a commit that referenced this issue May 20, 2024
@thaisguigon
feat: remove a link from a Links field
1de92bf 
Closes #5117
charlesBochet added a commit that referenced this issue May 22, 2024
@thaisguigon @magrinj @charlesBochet
feat: remove a link from a Links field (#5313)
4800388 
Closes #5117

TO FIX in another PR: right now, the "Vertical Dots" LightIconButton
inside the Dropdown menu sometimes needs to be clicked twice to open the
nested dropdown, not sure why 🤔 Maybe an `event.preventDefault()` is
needed somewhere?

<img width="369" alt="image"
src="https://github.com/twentyhq/twenty/assets/3098428/dd0c771a-c18d-4eb2-8ed6-b107f56711e9">

---------

Co-authored-by: Jérémy Magrin <jeremy.magrin@gmail.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thaisguigon thaisguigon

Labels
scope: back+front Issues requiring full-stack knowledge
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove a link from a Links field twentyhq/twenty
1 participant
@thaisguigon