New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove a link from a Links field #5313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaisguigon
force-pushed
the
feat/delete-link-from-links-field
branch
from
May 6, 2024 18:16
053dca6
to
507770b
Compare
thaisguigon
force-pushed
the
feat/delete-link-from-links-field
branch
from
May 7, 2024 13:07
507770b
to
83563b6
Compare
@thaisguigon could you rebase your PR on main, tests should be green :) |
thaisguigon
force-pushed
the
feat/delete-link-from-links-field
branch
from
May 8, 2024 08:21
83563b6
to
2350c4d
Compare
A1exKH
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
thaisguigon
force-pushed
the
feat/delete-link-from-links-field
branch
2 times, most recently
from
May 17, 2024 08:17
580cb86
to
556b5ab
Compare
Closes #5113
…move isPrimary property
thaisguigon
force-pushed
the
feat/delete-link-from-links-field
branch
from
May 20, 2024 13:09
556b5ab
to
2b04b90
Compare
charlesBochet
approved these changes
May 22, 2024
Log
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5117
TO FIX in another PR: right now, the "Vertical Dots" LightIconButton inside the Dropdown menu sometimes needs to be clicked twice to open the nested dropdown, not sure why 🤔 Maybe an
event.preventDefault()
is needed somewhere?