Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove a link from a Links field #5313

Merged
merged 6 commits into from May 22, 2024

Conversation

thaisguigon
Copy link
Contributor

@thaisguigon thaisguigon commented May 6, 2024

Closes #5117

TO FIX in another PR: right now, the "Vertical Dots" LightIconButton inside the Dropdown menu sometimes needs to be clicked twice to open the nested dropdown, not sure why 🤔 Maybe an event.preventDefault() is needed somewhere?

image

@thaisguigon thaisguigon force-pushed the feat/delete-link-from-links-field branch from 053dca6 to 507770b Compare May 6, 2024 18:16
Base automatically changed from feat/add-links-to-links-field to main May 7, 2024 13:05
@thaisguigon thaisguigon force-pushed the feat/delete-link-from-links-field branch from 507770b to 83563b6 Compare May 7, 2024 13:07
@charlesBochet
Copy link
Member

charlesBochet commented May 8, 2024

@thaisguigon could you rebase your PR on main, tests should be green :)

@thaisguigon thaisguigon force-pushed the feat/delete-link-from-links-field branch from 83563b6 to 2350c4d Compare May 8, 2024 08:21
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thaisguigon thaisguigon force-pushed the feat/delete-link-from-links-field branch 2 times, most recently from 580cb86 to 556b5ab Compare May 17, 2024 08:17
@thaisguigon thaisguigon force-pushed the feat/delete-link-from-links-field branch from 556b5ab to 2b04b90 Compare May 20, 2024 13:09
@charlesBochet charlesBochet merged commit 4800388 into main May 22, 2024
16 checks passed
@charlesBochet charlesBochet deleted the feat/delete-link-from-links-field branch May 22, 2024 07:39
Copy link

Fails
🚫

node failed.

Log

�[31mError: �[39m RequestError [HttpError]: Not Found
    at /home/runner/work/twenty/twenty/node_modules/�[4m@octokit�[24m/request/dist-node/index.js:86:21
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m {
  status: �[33m404�[39m,
  response: {
    url: �[32m'https://api.github.com/orgs/twentyhq/teams/core-team/members'�[39m,
    status: �[33m404�[39m,
    headers: {
      �[32m'access-control-allow-origin'�[39m: �[32m'*'�[39m,
      �[32m'access-control-expose-headers'�[39m: �[32m'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset'�[39m,
      connection: �[32m'close'�[39m,
      �[32m'content-encoding'�[39m: �[32m'gzip'�[39m,
      �[32m'content-security-policy'�[39m: �[32m"default-src 'none'"�[39m,
      �[32m'content-type'�[39m: �[32m'application/json; charset=utf-8'�[39m,
      date: �[32m'Wed, 22 May 2024 07:40:10 GMT'�[39m,
      �[32m'referrer-policy'�[39m: �[32m'origin-when-cross-origin, strict-origin-when-cross-origin'�[39m,
      server: �[32m'GitHub.com'�[39m,
      �[32m'strict-transport-security'�[39m: �[32m'max-age=31536000; includeSubdomains; preload'�[39m,
      �[32m'transfer-encoding'�[39m: �[32m'chunked'�[39m,
      vary: �[32m'Accept-Encoding, Accept, X-Requested-With'�[39m,
      �[32m'x-accepted-github-permissions'�[39m: �[32m'members=read'�[39m,
      �[32m'x-content-type-options'�[39m: �[32m'nosniff'�[39m,
      �[32m'x-frame-options'�[39m: �[32m'deny'�[39m,
      �[32m'x-github-api-version-selected'�[39m: �[32m'2022-11-28'�[39m,
      �[32m'x-github-media-type'�[39m: �[32m'github.v3; format=json'�[39m,
      �[32m'x-github-request-id'�[39m: �[32m'0647:342C50:442A0C7:7391FB5:664DA15A'�[39m,
      �[32m'x-ratelimit-limit'�[39m: �[32m'15000'�[39m,
      �[32m'x-ratelimit-remaining'�[39m: �[32m'14841'�[39m,
      �[32m'x-ratelimit-reset'�[39m: �[32m'1716365259'�[39m,
      �[32m'x-ratelimit-resource'�[39m: �[32m'core'�[39m,
      �[32m'x-ratelimit-used'�[39m: �[32m'159'�[39m,
      �[32m'x-xss-protection'�[39m: �[32m'0'�[39m
    },
    data: {
      message: �[32m'Not Found'�[39m,
      documentation_url: �[32m'https://docs.github.com/rest/teams/members#list-team-members'�[39m
    }
  },
  request: {
    method: �[32m'GET'�[39m,
    url: �[32m'https://api.github.com/orgs/twentyhq/teams/core-team/members'�[39m,
    headers: {
      accept: �[32m'application/vnd.github.v3+json'�[39m,
      �[32m'user-agent'�[39m: �[32m'octokit-rest.js/18.12.0 octokit-core.js/3.6.0 Node.js/18.20.2 (linux; x64)'�[39m,
      authorization: �[32m'token [REDACTED]'�[39m
    },
    request: { hook: �[36m[Function: bound bound register]�[39m }
  }
}
danger-results://tmp/danger-results-42c072b9.json

Generated by 🚫 dangerJS against 309cb19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Multi-links field] Delete url from list
4 participants