on-confirm-disabled-rename

[cogwizzle]

Renaming the onConfirmDisabled property in AlertDialog to be isConfirmDisabled so that the property is more transparent how it should be used. onConfirmDisabled reads more like it expects a function. isConfirmDisabled reads more like it expects a boolean. #3901

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

• I acknowledge that all my contributions will be made under the project's license.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[changeset-bot]

🦋 Changeset detected

Latest commit: 51544f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@twilio-paste/alert-dialog	Patch
@twilio-paste/core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

@cogwizzle is attempting to deploy a commit to the Twilio Team on Vercel.

A member of the Team first needs to authorize it.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 51544f8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 3 targets

• nx run-many --target=build:js --exclude @twilio-paste/website @twilio-paste/theme-designer
• nx run @twilio-paste/website:build
• nx run @twilio-paste/theme-designer:build

---

Sent with 💌 from NxCloud.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 51544f8:

Sandbox	Source
@twilio-paste/nextjs-template	Configuration
@twilio-paste/token-contrast-checker	Configuration

[nkrantz]

Thanks for this contribution! It's missing a changeset which will satisfy the failing Danger check (yarn run changeset) and then you'll need to also build the type docs (yarn build:typedocs) for the build to work properly. I'm happy to do these steps if you'd like!

[cogwizzle]

yarn run changeset

Let me give this a shot first. Thanks so much for reminding me. I'm still a bit new here. :)

[cogwizzle]

@nkrantz I think we should be in good shape now. Can you verify the update?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
paste-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 22, 2024 3:33pm
paste-remix	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 22, 2024 3:33pm

[nkrantz]

Thanks for making those changes @cogwizzle!

Did you run any commands other than yarn buid:typedocs? Somehow you got a bunch of other packages' types wrapped up in this PR, haven't seen that before. Might suggest removing the changes you didn't intend to make, then re-running the command. Otherwise looks great!

[cogwizzle]

Thanks for making those changes @cogwizzle!

Did you run any commands other than yarn buid:typedocs? Somehow you got a bunch of other packages' types wrapped up in this PR, haven't seen that before. Might suggest removing the changes you didn't intend to make, then re-running the command. Otherwise looks great!

I regenerated the types and it came up the same. It appears to mostly be a change in order on some of the types. Nothing major.

[nkrantz]

I regenerated the types and it came up the same. It appears to mostly be a change in order on some of the types. Nothing major.

Though most of them are just re-orders there are also a few actual additions and removals of props. I made the Alert Dialog changes on my end and generated type docs and only saw the Alert Dialog types modified. I don't feel great about merging these additional type changes (especially the removals) without understanding why they happened on your branch. The type check is also failing (PR Checks / Build system packages and type check). I'm going to look into this today and think about why yarn build:typedocs might not be working for you. Sorry about the delay with getting this PR in.

[nkrantz]

Closed this PR in favor of #3918