Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: moving off from url-parse #1017

Merged
merged 2 commits into from Apr 5, 2024
Merged

chore: moving off from url-parse #1017

merged 2 commits into from Apr 5, 2024

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

Currently, we use the url-parse package. This package is soft-deprecated - it's not actually throwing a deprecation warning, but the package's README urges users to switch to the built-in URL parser that now exists. The changes have been taken from #998

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tiwarishubham635 tiwarishubham635 mentioned this pull request Apr 5, 2024
Closed
8 tasks
@tiwarishubham635 tiwarishubham635 added type: twilio enhancement feature request on Twilio's roadmap status: work in progress Twilio or the community is in the process of implementing labels Apr 5, 2024
@tiwarishubham635
Copy link
Contributor Author

@43081j I hope this looks good to you. please check. Thanks!

43081j
43081j approved these changes Apr 5, 2024
View reviewed changes
Copy link

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thanks again for picking it up 🙏

@tiwarishubham635 tiwarishubham635 merged commit 18c6d6f into main Apr 5, 2024
14 checks passed
@tiwarishubham635 tiwarishubham635 deleted the remove_url_parse branch April 5, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@43081j 43081j 43081j approved these changes

@manisha1997 manisha1997 manisha1997 approved these changes

Assignees
No one assigned
Labels
status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiwarishubham635 @43081j @manisha1997