fix: cluster tests' twilio relative path dependency #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
claudiachua
approved these changes
Mar 15, 2023
childish-sambino
suggested changes
Mar 16, 2023
| "twilio": "../../package" | ||
| "twilio": "../../" |
There was a problem hiding this comment.
This is by-design as the cluster tests are intended to be run against the packed output:
twilio-node/.github/workflows/test-and-deploy.yml
Lines 44 to 49 in 4ab01b7
There was a problem hiding this comment.
I see. Thanks for the clarification. Closing this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the relative path used to install the twilio package from the parent directory for the cluster tests.
Closes #926