Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add lts version #989

Merged
merged 2 commits into from Jan 3, 2024
Merged

chore: add lts version #989

merged 2 commits into from Jan 3, 2024

Conversation

tiwarishubham635
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 commented Dec 26, 2023 •
edited

Fixes

Adds the Node LTS version in workflow
Earlier it was removed under this PR but this issue is now resolved

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@tiwarishubham635 tiwarishubham635 marked this pull request as draft December 26, 2023 13:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 26, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tiwarishubham635 tiwarishubham635 marked this pull request as ready for review December 26, 2023 13:30
shrutiburman
shrutiburman approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

axios/axios#5929

@tiwarishubham635 tiwarishubham635 merged commit dc1e741 into main Jan 3, 2024
15 checks passed
@tiwarishubham635 tiwarishubham635 deleted the add_lts_version branch January 3, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrutiburman shrutiburman shrutiburman approved these changes

@sbansla sbansla Awaiting requested review from sbansla

@kridai kridai Awaiting requested review from kridai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tiwarishubham635 @shrutiburman