Skip to content

Commit

Permalink
Merge commit
Browse files Browse the repository at this point in the history
commit 881c2c2
Author: childish-sambino <sharrison@twilio.com>
Date:   Fri Jan 27 16:15:49 2023 -0600

    test: look for all services, including those that are stopped, when checking status (#416)

commit 111ef95
Author: childish-sambino <sharrison@twilio.com>
Date:   Fri Jan 27 14:55:59 2023 -0600

    fix: move lib to src and dist to lib for node backwards-compatibility (#415)

commit a0b4320
Author: Isha Bansal <55244783+isha689@users.noreply.github.com>
Date:   Fri Jan 27 20:20:56 2023 +0530

    fix: set correct type for response properties (#409)

    <!--
    We appreciate the effort for this pull request but before that please
    make sure you read the contribution guidelines, then fill out the blanks
    below.

    Please format the PR title appropriately based on the type of change:
      <type>[!]: <description>
    Where <type> is one of: docs, chore, feat, fix, test, misc.
    Add a '!' after the type for breaking changes (e.g. feat!: new breaking
    feature).

    **All third-party contributors acknowledge that any contributions they
    provide will be made under the same open-source license that the
    open-source project is provided under.**

    Please enter each Issue number you are resolving in your PR after one of
    the following words [Fixes, Closes, Resolves]. This will auto-link these
    issues and close them when this PR is merged!
    e.g.
    Fixes #1
    Closes #2
    -->

    # Fixes [#727](twilio/twilio-php#727)

    Set correct dataType for nullable response properties.
    Jira link: https://issues.corp.twilio.com/browse/DII-789

    ### Checklist
    - [x] I acknowledge that all my contributions will be made under the
    project's license
    - [ ] Run `make test-docker`
    - [ ] Verify affected language:
    - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our
    [OpenAPI specification](https://github.com/twilio/twilio-oai) using the
    [build_twilio_go.py](./examples/build_twilio_go.py) using `python
    examples/build_twilio_go.py path/to/twilio-oai/spec/yaml
    path/to/twilio-go` and inspect the diff
        - [ ] Run `make test` in `twilio-go`
        - [ ] Create a pull request in `twilio-go`
        - [ ] Provide a link below to the pull request
    - [ ] I have made a material change to the repo (functionality, testing,
    spelling, grammar)
    - [ ] I have read the [Contribution
    Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)
    and my PR follows them
    - [ ] I have titled the PR appropriately
    - [ ] I have updated my branch with the main branch
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have added the necessary documentation about the functionality
    in the appropriate .md file
    - [ ] I have added inline documentation to the code I modified

    If you have questions, please create a GitHub Issue in this repository.

commit 780dd25
Author: Isha Bansal <55244783+isha689@users.noreply.github.com>
Date:   Fri Jan 27 10:25:53 2023 +0530

    fix: trailing comma (#414)

    <!--
    We appreciate the effort for this pull request but before that please
    make sure you read the contribution guidelines, then fill out the blanks
    below.

    Please format the PR title appropriately based on the type of change:
      <type>[!]: <description>
    Where <type> is one of: docs, chore, feat, fix, test, misc.
    Add a '!' after the type for breaking changes (e.g. feat!: new breaking
    feature).

    **All third-party contributors acknowledge that any contributions they
    provide will be made under the same open-source license that the
    open-source project is provided under.**

    Please enter each Issue number you are resolving in your PR after one of
    the following words [Fixes, Closes, Resolves]. This will auto-link these
    issues and close them when this PR is merged!
    e.g.
    Fixes #1
    Closes #2
    -->

    # Fixes #

    Removed the trailing comma within the function call.
    Correct alignment of braces.

    Cluster Tests successful run:
    [here](https://github.com/twilio/twilio-php/actions/runs/4014524180)

    ### Checklist
    - [x] I acknowledge that all my contributions will be made under the
    project's license
    - [ ] Run `make test-docker`
    - [ ] Verify affected language:
    - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our
    [OpenAPI specification](https://github.com/twilio/twilio-oai) using the
    [build_twilio_go.py](./examples/build_twilio_go.py) using `python
    examples/build_twilio_go.py path/to/twilio-oai/spec/yaml
    path/to/twilio-go` and inspect the diff
        - [ ] Run `make test` in `twilio-go`
        - [ ] Create a pull request in `twilio-go`
        - [ ] Provide a link below to the pull request
    - [ ] I have made a material change to the repo (functionality, testing,
    spelling, grammar)
    - [ ] I have read the [Contribution
    Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)
    and my PR follows them
    - [ ] I have titled the PR appropriately
    - [ ] I have updated my branch with the main branch
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have added the necessary documentation about the functionality
    in the appropriate .md file
    - [ ] I have added inline documentation to the code I modified

    If you have questions, please create a GitHub Issue in this repository.

commit 371df1c
Author: Claudia Chua <43133161+claudiachua@users.noreply.github.com>
Date:   Thu Jan 26 09:11:10 2023 +0800

    fix: remove camelcase duplicates domains (#413)

commit c2b17aa
Author: cchua <cchua@twilio.com>
Date:   Thu Jan 26 04:04:46 2023 +0800

    revert last commit

commit ca3adc4
Author: cchua <cchua@twilio.com>
Date:   Thu Jan 26 04:01:50 2023 +0800

    fix: remove camelcase duplicates domains

commit 8d060e2
Author: Rohith Prakash <rohithprakashklm@gmail.com>
Date:   Wed Jan 25 17:15:14 2023 +0530

    chore: Ruby add Page template (#412)

    <!--
    We appreciate the effort for this pull request but before that please
    make sure you read the contribution guidelines, then fill out the blanks
    below.

    Please format the PR title appropriately based on the type of change:
      <type>[!]: <description>
    Where <type> is one of: docs, chore, feat, fix, test, misc.
    Add a '!' after the type for breaking changes (e.g. feat!: new breaking
    feature).

    **All third-party contributors acknowledge that any contributions they
    provide will be made under the same open-source license that the
    open-source project is provided under.**

    Please enter each Issue number you are resolving in your PR after one of
    the following words [Fixes, Closes, Resolves]. This will auto-link these
    issues and close them when this PR is merged!
    e.g.
    Fixes #1
    Closes #2
    -->

    # Chore #

    Adds ruby page class template

    ### Checklist
    - [x] I acknowledge that all my contributions will be made under the
    project's license
    - [ ] Run `make test-docker`
    - [ ] Verify affected language:
    - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our
    [OpenAPI specification](https://github.com/twilio/twilio-oai) using the
    [build_twilio_go.py](./examples/build_twilio_go.py) using `python
    examples/build_twilio_go.py path/to/twilio-oai/spec/yaml
    path/to/twilio-go` and inspect the diff
        - [ ] Run `make test` in `twilio-go`
        - [ ] Create a pull request in `twilio-go`
        - [ ] Provide a link below to the pull request
    - [ ] I have made a material change to the repo (functionality, testing,
    spelling, grammar)
    - [ ] I have read the [Contribution
    Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)
    and my PR follows them
    - [ ] I have titled the PR appropriately
    - [ ] I have updated my branch with the main branch
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have added the necessary documentation about the functionality
    in the appropriate .md file
    - [ ] I have added inline documentation to the code I modified

    If you have questions, please create a GitHub Issue in this repository.

commit 6ed2a9f
Author: Isha Bansal <55244783+isha689@users.noreply.github.com>
Date:   Tue Jan 24 16:58:13 2023 +0530

    fix: type hint for $capabilities to PhoneNumberCapabilities (#404)

    <!--
    We appreciate the effort for this pull request but before that please
    make sure you read the contribution guidelines, then fill out the blanks
    below.

    Please format the PR title appropriately based on the type of change:
      <type>[!]: <description>
    Where <type> is one of: docs, chore, feat, fix, test, misc.
    Add a '!' after the type for breaking changes (e.g. feat!: new breaking
    feature).

    **All third-party contributors acknowledge that any contributions they
    provide will be made under the same open-source license that the
    open-source project is provided under.**

    Please enter each Issue number you are resolving in your PR after one of
    the following words [Fixes, Closes, Resolves]. This will auto-link these
    issues and close them when this PR is merged!
    e.g.
    Fixes #1
    Closes #2
    -->

    # Fixes #

    Fixes [php-issue](twilio/twilio-php#627)
    Ref: [PR](twilio/twilio-php#760)
    Made changes in Dockerfile because the generated src folder will depend
    on [Deserialize::
    phoneNumberCapabilities()](https://github.com/twilio/twilio-php/blob/DII-790/src/Twilio/Deserialize.php#L34)
    which is to be merged into rc-branch.
    **Note: Dockerfile changes to be reverted before MVR release**

    ### Checklist
    - [x] I acknowledge that all my contributions will be made under the
    project's license
    - [ ] Run `make test-docker`
    - [ ] Verify affected language:
    - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our
    [OpenAPI specification](https://github.com/twilio/twilio-oai) using the
    [build_twilio_go.py](./examples/build_twilio_go.py) using `python
    examples/build_twilio_go.py path/to/twilio-oai/spec/yaml
    path/to/twilio-go` and inspect the diff
        - [ ] Run `make test` in `twilio-go`
        - [ ] Create a pull request in `twilio-go`
        - [ ] Provide a link below to the pull request
    - [ ] I have made a material change to the repo (functionality, testing,
    spelling, grammar)
    - [ ] I have read the [Contribution
    Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)
    and my PR follows them
    - [ ] I have titled the PR appropriately
    - [ ] I have updated my branch with the main branch
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have added the necessary documentation about the functionality
    in the appropriate .md file
    - [ ] I have added inline documentation to the code I modified

    If you have questions, please create a GitHub Issue in this repository.

commit fee7ea3
Author: Charanjeet Singh <chsingh@twilio.com>
Date:   Tue Jan 24 13:15:49 2023 +0530

    fix: Php lint issues (#411)

    <!--
    We appreciate the effort for this pull request but before that please
    make sure you read the contribution guidelines, then fill out the blanks
    below.

    Please format the PR title appropriately based on the type of change:
      <type>[!]: <description>
    Where <type> is one of: docs, chore, feat, fix, test, misc.
    Add a '!' after the type for breaking changes (e.g. feat!: new breaking
    feature).

    **All third-party contributors acknowledge that any contributions they
    provide will be made under the same open-source license that the
    open-source project is provided under.**

    Please enter each Issue number you are resolving in your PR after one of
    the following words [Fixes, Closes, Resolves]. This will auto-link these
    issues and close them when this PR is merged!
    e.g.
    Fixes #1
    Closes #2
    -->

    # Fixes #

    - Fix sonar lint issues for php generated example files
    - Fix php template files and generated path string from phpAPIBuilder

    ### Checklist
    - [x] I acknowledge that all my contributions will be made under the
    project's license
    - [ ] Run `make test-docker`
    - [ ] Verify affected language:
    - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our
    [OpenAPI specification](https://github.com/twilio/twilio-oai) using the
    [build_twilio_go.py](./examples/build_twilio_go.py) using `python
    examples/build_twilio_go.py path/to/twilio-oai/spec/yaml
    path/to/twilio-go` and inspect the diff
        - [ ] Run `make test` in `twilio-go`
        - [ ] Create a pull request in `twilio-go`
        - [ ] Provide a link below to the pull request
    - [ ] I have made a material change to the repo (functionality, testing,
    spelling, grammar)
    - [ ] I have read the [Contribution
    Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)
    and my PR follows them
    - [ ] I have titled the PR appropriately
    - [ ] I have updated my branch with the main branch
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have added the necessary documentation about the functionality
    in the appropriate .md file
    - [ ] I have added inline documentation to the code I modified

    If you have questions, please create a GitHub Issue in this repository.

commit 78d623d
Author: childish-sambino <sharrison@twilio.com>
Date:   Fri Jan 20 09:51:28 2023 -0600

    fix: refactor API filename generation for ruby (#408)

    Node examples are currently broken. This fixes it.
  • Loading branch information
shrutiburman committed Jan 29, 2023
1 parent 2e77a7c commit dcbdeb3
Show file tree
Hide file tree
Showing 109 changed files with 1,872 additions and 734 deletions.
4 changes: 2 additions & 2 deletions examples/node/Dockerfile
Expand Up @@ -4,9 +4,9 @@ WORKDIR /app
RUN git clone https://github.com/twilio/twilio-node.git
WORKDIR /app/twilio-node/

RUN rm -rf lib/rest/ spec/
RUN rm -rf src/rest/ spec/

COPY lib lib
COPY src src
COPY spec spec

# pipefail prevents errors in a pipeline from being masked.
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Expand Up @@ -20,8 +20,8 @@ const deserialize = require("../../../base/deserialize");
const serialize = require("../../../base/serialize");
import { isValidPathParam } from "../../../base/utility";
import { CallListInstance } from "./account/call";
import { PhoneNumberCapabilities } from "../../../../lib/interfaces";
import TwiML from "../../../../lib/twiml/TwiML";
import { PhoneNumberCapabilities } from "../../../../src/interfaces";
import TwiML from "../../../../src/twiml/TwiML";

export class TestResponseObjectTestArrayOfObjects {
"count"?: number;
Expand Down
Expand Up @@ -18,7 +18,7 @@ const deserialize = require("../../../../base/deserialize");
const serialize = require("../../../../base/serialize");
import { isValidPathParam } from "../../../../base/utility";
import { FeedbackCallSummaryListInstance } from "./call/feedbackCallSummary";
import { PhoneNumberCapabilities } from "../../../../../lib/interfaces";
import { PhoneNumberCapabilities } from "../../../../../src/interfaces";

export class TestResponseObjectTestArrayOfObjects {
"count"?: number;
Expand Down
Expand Up @@ -17,7 +17,7 @@ import V2010 from "../../../V2010";
const deserialize = require("../../../../../base/deserialize");
const serialize = require("../../../../../base/serialize");
import { isValidPathParam } from "../../../../../base/utility";
import { PhoneNumberCapabilities } from "../../../../../../lib/interfaces";
import { PhoneNumberCapabilities } from "../../../../../../src/interfaces";

export class TestResponseObjectTestArrayOfObjects {
"count"?: number;
Expand Down
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/php/Dockerfile
Expand Up @@ -9,7 +9,7 @@ ENV PATH="vendor/bin:$PATH"
RUN pecl install xdebug-2.9.0
RUN pecl install pcov && docker-php-ext-enable pcov

RUN git clone https://github.com/twilio/twilio-php.git twilio
RUN git clone -b 7.0.0-rc https://github.com/twilio/twilio-php.git twilio
WORKDIR /twilio

RUN rm -rf src/Twilio/Rest/*
Expand Down
29 changes: 19 additions & 10 deletions examples/php/src/Twilio/Rest/Api/V2010.php
Expand Up @@ -30,7 +30,8 @@
* @method \Twilio\Rest\Api\V2010\AccountContext accounts(string $sid)
* @method \Twilio\Rest\Api\V2010\Account\CallContext calls(string $testInteger)
*/
class V2010 extends Version {
class V2010 extends Version
{
protected $_accounts;
protected $_account = null;
protected $_calls = null;
Expand All @@ -40,12 +41,14 @@ class V2010 extends Version {
*
* @param Domain $domain Domain that contains the version
*/
public function __construct(Domain $domain) {
public function __construct(Domain $domain)
{
parent::__construct($domain);
$this->version = '2010-04-01';
}

protected function getAccounts(): AccountList {
protected function getAccounts(): AccountList
{
if (!$this->_accounts) {
$this->_accounts = new AccountList($this);
}
Expand All @@ -55,7 +58,8 @@ protected function getAccounts(): AccountList {
/**
* @return AccountContext Account provided as the authenticating account
*/
protected function getAccount(): AccountContext {
protected function getAccount(): AccountContext
{
if (!$this->_account) {
$this->_account = new AccountContext(
$this,
Expand All @@ -71,11 +75,13 @@ protected function getAccount(): AccountContext {
* @param AccountContext|AccountInstance $account account to use as the primary
* account
*/
public function setAccount($account): void {
public function setAccount($account): void
{
$this->_account = $account;
}

protected function getCalls(): \Twilio\Rest\Api\V2010\Account\CallList {
protected function getCalls(): \Twilio\Rest\Api\V2010\Account\CallList
{
return $this->account->calls;
}

Expand All @@ -86,7 +92,8 @@ protected function getCalls(): \Twilio\Rest\Api\V2010\Account\CallList {
* @return \Twilio\ListResource The requested resource
* @throws TwilioException For unknown resource
*/
public function __get(string $name) {
public function __get(string $name)
{
$method = 'get' . \ucfirst($name);
if (\method_exists($this, $method)) {
return $this->$method();
Expand All @@ -103,7 +110,8 @@ public function __get(string $name) {
* @return InstanceContext The requested resource context
* @throws TwilioException For unknown resource
*/
public function __call(string $name, array $arguments): InstanceContext {
public function __call(string $name, array $arguments): InstanceContext
{
$property = $this->$name;
if (\method_exists($property, 'getContext')) {
return \call_user_func_array(array($property, 'getContext'), $arguments);
Expand All @@ -117,7 +125,8 @@ public function __call(string $name, array $arguments): InstanceContext {
*
* @return string Machine friendly representation
*/
public function __toString(): string {
public function __toString(): string
{
return '[Twilio.Api.V2010]';
}
}
}
Expand Up @@ -27,59 +27,79 @@
use Twilio\InstanceContext;
use Twilio\Deserialize;
use Twilio\Serialize;
use Twilio\Base\PhoneNumberCapabilities;


class FeedbackCallSummaryContext extends InstanceContext {
class FeedbackCallSummaryContext extends InstanceContext
{
/**
* Initialize the FeedbackCallSummaryContext
*
* @param Version $version Version that contains the resource
* @param string $accountSid
* @param string $sid
* @param string $accountSid
* @param string $sid
*/
public function __construct(Version $version, $accountSid , $sid ) {
public function __construct(
Version $version,
$accountSid,
$sid
) {
parent::__construct($version);

// Path Solution
$this->solution = ['accountSid' => $accountSid, 'sid' => $sid, ];
$this->solution = [
'accountSid' =>
$accountSid,
'sid' =>
$sid,
];

$this->uri = '/Accounts/' . \rawurlencode($accountSid) . '/Calls/Feedback/Summary/' . \rawurlencode($sid) . '.json';
$this->uri = '/Accounts/' . \rawurlencode($accountSid)
.'/Calls/Feedback/Summary/' . \rawurlencode($sid)
.'.json';
}

/**
* Update the FeedbackCallSummaryInstance
*
* @param \DateTime $endDate
* @param \DateTime $startDate
* @param \DateTime $endDate
* @param \DateTime $startDate
* @param array|Options $options Optional Arguments
* @return FeedbackCallSummaryInstance Updated FeedbackCallSummaryInstance
* @throws TwilioException When an HTTP error occurs.
*/
public function update(\DateTime $endDate, \DateTime $startDate, array $options = []): FeedbackCallSummaryInstance {
public function update(\DateTime $endDate, \DateTime $startDate, array $options = []): FeedbackCallSummaryInstance
{

$options = new Values($options);

$data = Values::of([
'EndDate' => Serialize::iso8601Date($endDate),
'StartDate' => Serialize::iso8601Date($startDate),
'AccountSid' => $options['accountSid'],
'EndDate' =>
Serialize::iso8601Date($endDate),
'StartDate' =>
Serialize::iso8601Date($startDate),
'AccountSid' =>
$options['accountSid'],
]);

$payload = $this->version->update('POST', $this->uri, [], $data);

return new FeedbackCallSummaryInstance(
$this->version,
$payload
, $this->solution['accountSid']
, $this->solution['sid']
$payload,
$this->solution['accountSid'],
$this->solution['sid']
);
}


/**
* Provide a friendly representation
*
* @return string Machine friendly representation
*/
public function __toString(): string {
public function __toString(): string
{
$context = [];
foreach ($this->solution as $key => $value) {
$context[] = "$key=$value";
Expand Down
Expand Up @@ -27,36 +27,39 @@
use Twilio\InstanceContext;
use Twilio\Deserialize;
use Twilio\Serialize;
use Twilio\Base\PhoneNumberCapabilities;


/**
* @property string $accountSid
* @property string $sid
* @property string $testString
* @property int $testInteger
* @property string $testObject
* @property \DateTime $testDateTime
* @property string $testNumber
* @property string $priceUnit
* @property string $testNumberFloat
* @property string $testNumberDecimal
* @property string|null $accountSid
* @property string|null $sid
* @property string|null $testString
* @property int|null $testInteger
* @property PhoneNumberCapabilities|null $testObject
* @property \DateTime|null $testDateTime
* @property string|null $testNumber
* @property string|null $priceUnit
* @property string|null $testNumberFloat
* @property string|null $testNumberDecimal
* @property string $testEnum
* @property string $a2PProfileBundleSid
* @property string|null $a2PProfileBundleSid
* @property int[] $testArrayOfIntegers
* @property int[][] $testArrayOfArrayOfIntegers
* @property string[] $testArrayOfObjects
* @property string[] $testArrayOfEnum
* @property string[]|null $testArrayOfObjects
* @property string[]|null $testArrayOfEnum
*/
class FeedbackCallSummaryInstance extends InstanceResource {
class FeedbackCallSummaryInstance extends InstanceResource
{
/**
* Initialize the FeedbackCallSummaryInstance
*
* @param Version $version Version that contains the resource
* @param mixed[] $payload The response payload
* @param string $accountSid
* @param string $sid
* @param string $accountSid
* @param string $sid
*/
public function __construct(Version $version, array $payload, string $accountSid, string $sid = null) {
public function __construct(Version $version, array $payload, string $accountSid, string $sid = null)
{
parent::__construct($version);

// Marshaled Properties
Expand All @@ -65,7 +68,7 @@ public function __construct(Version $version, array $payload, string $accountSid
'sid' => Values::array_get($payload, 'sid'),
'testString' => Values::array_get($payload, 'test_string'),
'testInteger' => Values::array_get($payload, 'test_integer'),
'testObject' => Values::array_get($payload, 'test_object'),
'testObject' => Deserialize::phoneNumberCapabilities(Values::array_get($payload, 'test_object')),
'testDateTime' => Deserialize::dateTime(Values::array_get($payload, 'test_date_time')),
'testNumber' => Values::array_get($payload, 'test_number'),
'priceUnit' => Values::array_get($payload, 'price_unit'),
Expand All @@ -88,7 +91,8 @@ public function __construct(Version $version, array $payload, string $accountSid
*
* @return FeedbackCallSummaryContext Context for this FeedbackCallSummaryInstance
*/
protected function proxy(): FeedbackCallSummaryContext {
protected function proxy(): FeedbackCallSummaryContext
{
if (!$this->context) {
$this->context = new FeedbackCallSummaryContext(
$this->version,
Expand All @@ -103,13 +107,15 @@ protected function proxy(): FeedbackCallSummaryContext {
/**
* Update the FeedbackCallSummaryInstance
*
* @param \DateTime $endDate
* @param \DateTime $startDate
* @param \DateTime $endDate
* @param \DateTime $startDate
* @param array|Options $options Optional Arguments
* @return FeedbackCallSummaryInstance Updated FeedbackCallSummaryInstance
* @throws TwilioException When an HTTP error occurs.
*/
public function update(\DateTime $endDate, \DateTime $startDate, array $options = []): FeedbackCallSummaryInstance {
public function update(\DateTime $endDate, \DateTime $startDate, array $options = []): FeedbackCallSummaryInstance
{

return $this->proxy()->update($endDate, $startDate, $options);
}

Expand All @@ -120,7 +126,8 @@ public function update(\DateTime $endDate, \DateTime $startDate, array $options
* @return mixed The requested property
* @throws TwilioException For unknown properties
*/
public function __get(string $name) {
public function __get(string $name)
{
if (\array_key_exists($name, $this->properties)) {
return $this->properties[$name];
}
Expand All @@ -138,7 +145,8 @@ public function __get(string $name) {
*
* @return string Machine friendly representation
*/
public function __toString(): string {
public function __toString(): string
{
$context = [];
foreach ($this->solution as $key => $value) {
$context[] = "$key=$value";
Expand Down

0 comments on commit dcbdeb3

Please sign in to comment.