Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use relative root for library type imports in node #422

Merged
merged 1 commit into from Feb 1, 2023
Merged

fix: use relative root for library type imports in node #422

merged 1 commit into from Feb 1, 2023

Conversation

childish-sambino
Copy link
Contributor

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

[twilio-oai-generator-python] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

[twilio-oai-generator-java] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

[twilio-oai-generator-go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

[twilio-oai-generator-node] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

[twilio-oai-generator-php] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@childish-sambino childish-sambino merged commit dcce1b8 into main Feb 1, 2023
@childish-sambino childish-sambino deleted the node-types-imports branch February 1, 2023 17:41
shrutiburman added a commit that referenced this pull request Feb 13, 2023
@shrutiburman
Squashed commit of the following:
6c07f3b 
commit 475e098
Author: childish-sambino <sharrison@twilio.com>
Date:   Thu Feb 2 13:55:42 2023 -0600

    feat: handle additional pagination parameters (#425)

    Also fixes comment ordering in some C# files.

commit 9c1e40d
Author: childish-sambino <sharrison@twilio.com>
Date:   Thu Feb 2 10:56:24 2023 -0600

    chore: refactor handling of path account SIDs (#421)

    No changes to generated code. Enables Go codegens to utilize the DirectoryStructureService.

commit b0cbfc9
Author: kridai <kgoswami@twilio.com>
Date:   Thu Feb 2 10:26:00 2023 +0530

    feat: add sonar support for ruby (#384)

    <!--
    We appreciate the effort for this pull request but before that please
    make sure you read the contribution guidelines, then fill out the blanks
    below.

    Please format the PR title appropriately based on the type of change:
      <type>[!]: <description>
    Where <type> is one of: docs, chore, feat, fix, test, misc.
    Add a '!' after the type for breaking changes (e.g. feat!: new breaking
    feature).

    **All third-party contributors acknowledge that any contributions they
    provide will be made under the same open-source license that the
    open-source project is provided under.**

    Please enter each Issue number you are resolving in your PR after one of
    the following words [Fixes, Closes, Resolves]. This will auto-link these
    issues and close them when this PR is merged!
    e.g.
    Fixes #1
    Closes #2
    -->

    # Fixes #

    Closes : DII-751,
    setting up sonar monorepo for ruby

    ### Checklist
    - [x] I acknowledge that all my contributions will be made under the
    project's license
    - [ ] Run `make test-docker`
    - [ ] Verify affected language:
    - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our
    [OpenAPI specification](https://github.com/twilio/twilio-oai) using the
    [build_twilio_go.py](./examples/build_twilio_go.py) using `python
    examples/build_twilio_go.py path/to/twilio-oai/spec/yaml
    path/to/twilio-go` and inspect the diff
        - [ ] Run `make test` in `twilio-go`
        - [ ] Create a pull request in `twilio-go`
        - [ ] Provide a link below to the pull request
    - [ ] I have made a material change to the repo (functionality, testing,
    spelling, grammar)
    - [ ] I have read the [Contribution
    Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)
    and my PR follows them
    - [ ] I have titled the PR appropriately
    - [ ] I have updated my branch with the main branch
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have added the necessary documentation about the functionality
    in the appropriate .md file
    - [ ] I have added inline documentation to the code I modified

    If you have questions, please create a GitHub Issue in this repository.

commit dcce1b8
Author: childish-sambino <sharrison@twilio.com>
Date:   Wed Feb 1 11:41:39 2023 -0600

    fix: use relative root for library type imports in node (#422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beebzz beebzz beebzz approved these changes

@mattcole19 mattcole19 mattcole19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@childish-sambino @beebzz @mattcole19