-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run end to end test pipeline for iOS. #20
base: dev
Are you sure you want to change the base?
Run end to end test pipeline for iOS. #20
Conversation
.circleci/config.yml
Outdated
--header "Circle-Token: $CIRCLE_TOKEN" \ | ||
--header "Content-Type: application/json" \ | ||
--data '{ | ||
"branch":"aorozcobuiles/ACCSEC-33579/EndToEndTestPipelineConnection", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it avoid using a task/feature branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to define the branch as we have a branch for testing, just updated it
632a5d8
to
8b51dd5
Compare
.circleci/config.yml
Outdated
- run-ios-internal-sdk-e2e-tests | ||
- check-status-of-triggered-ios-pipeline: | ||
requires: | ||
- wait-for-ios-internal-sdk-e2e-tests | ||
- wait-for-internal-sdk-e2e-tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to wait-for-android-internal-sdk-e2e-tests
?
) | ||
echo "<< pipeline.id >>" | ||
echo "Created pipeline: $CREATED_PIPELINE" | ||
./scripts/add_env_variable_to_file.sh CREATED_PIPELINE $CREATED_PIPELINE $TMP_WORKSPACE $ENV_VARS_FILE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use a different env variable to store this pipeline? Android uses the same key, it could cause issues when both jobs are running in parallel at the same time. When you change it, can you also modify the Android to match the same naming convention you used for iOS?
puts "Printing files" | ||
puts `ls -l -p ../` | ||
puts `ls -l -p ../IPAs/` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these prints for testing? Can they be removed?
…orozcobuiles/ACCSEC-33579/EndToEndTestPipelineConnection
Generated by 🚫 Danger |
Generated by 🚫 Danger |
Generated by 🚫 Danger |
Ticket
Github Issue
Description
Commit message
Testing