Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run end to end test pipeline for iOS. #20

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from

Conversation

AlejandroOrozco
Copy link
Collaborator

Ticket

  • [ACCSEC-33579]

Github Issue

  • ISSUE-

Description

Commit message

  • Run end to end test pipeline for iOS.
Pipeline List Pipeline Graph
Screenshot 2024-03-26 at 10 50 18 PM Screenshot 2024-03-26 at 10 50 45 PM

Testing

  • Added unit tests
  • Ran unit tests successfully
  • Added documentation for public APIs and/or Wiki

@AlejandroOrozco AlejandroOrozco self-assigned this Mar 26, 2024
@AlejandroOrozco AlejandroOrozco requested a review from a team as a code owner March 26, 2024 21:52
--header "Circle-Token: $CIRCLE_TOKEN" \
--header "Content-Type: application/json" \
--data '{
"branch":"aorozcobuiles/ACCSEC-33579/EndToEndTestPipelineConnection",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it avoid using a task/feature branch?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to define the branch as we have a branch for testing, just updated it

@yafuquen yafuquen changed the title [ACCSEC-33579] - Run end to end test pipeline for iOS. Run end to end test pipeline for iOS. Apr 8, 2024
@AlejandroOrozco AlejandroOrozco force-pushed the aorozcobuiles/ACCSEC-33579/EndToEndTestPipelineConnection branch from 632a5d8 to 8b51dd5 Compare April 16, 2024 20:29
- run-ios-internal-sdk-e2e-tests
- check-status-of-triggered-ios-pipeline:
requires:
- wait-for-ios-internal-sdk-e2e-tests
- wait-for-internal-sdk-e2e-tests:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to wait-for-android-internal-sdk-e2e-tests?

)
echo "<< pipeline.id >>"
echo "Created pipeline: $CREATED_PIPELINE"
./scripts/add_env_variable_to_file.sh CREATED_PIPELINE $CREATED_PIPELINE $TMP_WORKSPACE $ENV_VARS_FILE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use a different env variable to store this pipeline? Android uses the same key, it could cause issues when both jobs are running in parallel at the same time. When you change it, can you also modify the Android to match the same naming convention you used for iOS?

Comment on lines +109 to +111
puts "Printing files"
puts `ls -l -p ../`
puts `ls -l -p ../IPAs/`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these prints for testing? Can they be removed?

@authid-sdk-ci
Copy link

🧛 shared module Code Coverage: 96.16%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

Fastfile
config.yml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@authid-sdk-ci
Copy link

1 Warning
⚠️ IPA size: 1.9 MB
App size: 6.6 MB
TwilioPasskeys.framework: 5.5 MB, Impact: 84.2%

Generated by 🚫 Danger

@authid-sdk-ci
Copy link

1 Warning
⚠️ The Pull Request title does not follow the convention [00000] PR Title text

Generated by 🚫 Danger

@authid-sdk-ci
Copy link

1 Warning
⚠️

Size impact

ABI APK Size Impact
x86 2MB
x86_64 2MB
armeabi-v7a 2MB
arm64-v8a 2MB
universal 2MB

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants