IDSK-2547 Re-writing AVPlayerExample #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushtank
changed the title
piyushtank
commented
Jun 27, 2019
| #import "TPCircularBuffer+AudioBufferList.h" | ||
|
|
||
| // We want to get as close to 20 msec buffers as possible, to match the behavior of TVIDefaultAudioDevice. | ||
| static double const kPreferredIOBufferDuration = 0.01; |
There was a problem hiding this comment.
Use kPreferredIOBufferDuration as 0.02
piyushtank
commented
Jun 27, 2019
| // We want to get as close to 20 msec buffers as possible, to match the behavior of TVIDefaultAudioDevice. | ||
| static double const kPreferredIOBufferDuration = 0.01; | ||
| // We will use stereo playback where available. Some audio routes may be restricted to mono only. | ||
| static size_t const kPreferredNumberOfChannels = 1; |
There was a problem hiding this comment.
Can we use hint from AVPlayer to determine mono vs stereo
piyushtank
commented
Jun 27, 2019
| framesToCopy, | ||
| &sourceRange, | ||
| kPreferredNumberOfChannels); | ||
| } |
There was a problem hiding this comment.
Lets make sure we are not turning on the capturing sample rate conversion stream on the tap.
piyushtank
commented
Jun 27, 2019
| rootVC.connect(contentUrl: videoUrl) | ||
| } | ||
| return true | ||
| } |
There was a problem hiding this comment.
- Lets use Twilio's video
- Do not launch with URL, remove plist entry.
| videoPlayerView?.removeFromSuperview() | ||
| videoPlayerView = nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Add a comment why we are doing prerollVideoPlayer
|
|
||
| @IBAction func toggleAudioMixing(_ sender: Any) { | ||
| // TODO: Pause/stop audio mixing on demand | ||
| } |
There was a problem hiding this comment.
toggleAudioMixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
This pull requests replaces re-implements the AVPlayerExample -
The example uses the AudioDevice implemented in Co-Viewing example #325 .
TODOs