feat: add timeout config to websocket (#613)

twitch4j · Jul 28, 2022 · 76a42fa · 76a42fa
1 parent 55b99ad
commit 76a42fa
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/client-websocket/src/main/java/com/github/twitch4j/client/websocket/WebsocketConnection.java b/client-websocket/src/main/java/com/github/twitch4j/client/websocket/WebsocketConnection.java
@@ -70,7 +70,10 @@ public WebsocketConnection(Consumer<WebsocketConnectionConfig> configSpec) {
         config = WebsocketConnectionConfig.process(configSpec);
 
         // webSocketFactory and proxy configuration
-        this.webSocketFactory = new WebSocketFactory();
+        this.webSocketFactory = new WebSocketFactory()
+            .setConnectionTimeout(config.connectionTimeout())
+            .setSocketTimeout(config.socketTimeout());
+
         if (config.proxyConfig() != null) {
             webSocketFactory.getProxySettings()
                 .setHost(config.proxyConfig().getHostname())

diff --git a/...bsocket/src/main/java/com/github/twitch4j/client/websocket/WebsocketConnectionConfig.java b/...bsocket/src/main/java/com/github/twitch4j/client/websocket/WebsocketConnectionConfig.java
@@ -36,6 +36,12 @@ public void validate() {
         if (wsPingPeriod < 0) {
             throw new RuntimeException("wsPingPeriod must be 0 or greater, set to 0 to disable!");
         }
+        if (connectionTimeout < 0) {
+            throw new RuntimeException("connectionTimeout must be 0 or greater, set to 0 to disable!");
+        }
+        if (socketTimeout < 0) {
+            throw new RuntimeException("socketTimeout must be 0 or greater, set to 0 to disable!");
+        }
         Objects.requireNonNull(taskExecutor, "taskExecutor may not be null!");
         Objects.requireNonNull(backoffStrategy, "backoffStrategy may not be null!");
         Objects.requireNonNull(onStateChanged, "onStateChanged may not be null!");
@@ -59,6 +65,16 @@ public void validate() {
      */
     private int wsPingPeriod = 0;
 
+    /**
+     * Websocket timeout milliseconds for establishing a connection (0 = disabled).
+     */
+    private int connectionTimeout = 60_000;
+
+    /**
+     * Websocket timeout milliseconds for read and write operations (0 = disabled).
+     */
+    private int socketTimeout = 10_000;
+
     /**
      * WebSocket Headers
      */