Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: modernize timestamps, rename fields, improve javadocs #186

Merged
merged 3 commits into from Sep 13, 2020
Merged

refactor: modernize timestamps, rename fields, improve javadocs #186

merged 3 commits into from Sep 13, 2020

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Sep 11, 2020 •
edited

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • Work towards Improve TwitchClientHelper class #61
  • TwitchHelix#getClips: passing a Date (for startedAt or endedAt) would always result in failure due to its toString method not yielding a RFC 3339 compliant format

Changes Proposed

  • LocalDateTime, Date, Calendar => Instant
  • Improve documentation of Moderator and ModeratorEvent
  • Rename subscriptions field in ModeratorList and ModeratorEventList

@iProdigy iProdigy marked this pull request as draft September 11, 2020 19:52
@iProdigy iProdigy marked this pull request as ready for review September 11, 2020 21:09
@iProdigy iProdigy changed the title refactor: prefer instant to localdatetime, rename fields, improve javadocs refactor: modernize timestamps, rename fields, improve javadocs Sep 11, 2020
PhilippHeuer
PhilippHeuer approved these changes Sep 13, 2020
View reviewed changes
Copy link
Member

@PhilippHeuer PhilippHeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Instant is a better choice for the timestamps.

Good job adding all the deprecated functions that have the old names / types - and also for fixing the name in getModerators, i didn't notice that.

@PhilippHeuer PhilippHeuer merged commit 2bfadc7 into develop Sep 13, 2020
@iProdigy iProdigy deleted the refactor/avoid-local-date branch September 13, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer