-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(gradle): Kotlin DSL build and Dependabot #243
build(gradle): Kotlin DSL build and Dependabot #243
Conversation
with extended functions in `buildSrc` and `gradle.properties` (group and version)
for kotlin dsl builds. Dependabot preview will not work for the kotlin dsl builds.
5bc6213
to
c734fae
Compare
I'll hold kotlin dsl changes. The bug is more complex that we can imagine it. Extended functions defined for dependencies will be break it, if you try fetching jar resources classes (I think). To avoid that we will use a quoted configuration like that: Simple: Using kotlin-dsl with |
- added missing eventsub-common - refactor and added missing dependencies - adding missing dsl's - bumping gradle to 6.8 - update to base branch `develop`
resolve conflict with configurations. For later
Mentioned in discord private chat, and i guess i can ready to merge that
This is ready to review and deploy. Only some typings (spaces, new-lines, etc.). |
…uild/gradle-kts-dependabot
gradle build incorrect version between lombok and project
I put some suggestion comments here. Everything is ready to review. I see some changes adding to central repository soo i can close #270 if there is no issue? |
backtick quoting is not needed for that
Co-authored-by: Damian Staszewski <359222+stachu540@users.noreply.github.com>
update badges: - adds javadoc - add link to central - "WIKI" names renamed to "documentation" and colored to "grey" - all badges style are flat (not square)
`project.kt` - CI Management to GitLab Pipelines - for now `globals.kt` - artifactId variable listing adjustment for better readable code lookup
I have add manifest plugin to this branch. Will be added in all jars because this plugin adds only add for |
…into build/gradle-kts-dependabot
Co-authored-by: Sidd <iProdigy@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your hard work on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
artifactId
will be setted in here
Yes, but the generated artifactId's from the module names don't match the existing artifact names we published in the past, so i used fixed values everywhere to make sure it's pushed correctly. |
Prerequisites for Code Changes
Changes Proposed
kotlin-dsl
.github/dependabot.yml
for dependenciesAdditional Information
Revmaped build to Kotlin DSL will help simplify build library. Creating
buildSrc
and provide function and his extensions gives oportunity to doing some cleanup. Of course createdgradle.properties
provides onlygroup
andversion
. If you wish extracting version from environmental variables i can move it tobuildSrc/src/main/kotlin/_globals.kt
which are having more environmental variables definition into property when they are accessible for all projects. All changes are tested without no issue (for now). WARNING: Do not addapply false
intoplugins
definition. It cause exceptions of missing properties or functions, which are be not loaded if you didn't apply plugin inside the file. More about cross configuration project will find hereDependabot is supported for Kotlin DSL. Preview version doesn't have it this feature.
After resolving #244 i will start resolve this PR. For now marking him as Draft.