New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add micrometer support #594
Open
PhilippHeuer
wants to merge
24
commits into
develop
Choose a base branch
from
feature/micrometer
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippHeuer
force-pushed
the
feature/micrometer
branch
from
July 25, 2022 18:06
8931e73
to
da5589b
Compare
PhilippHeuer
force-pushed
the
feature/micrometer
branch
2 times, most recently
from
February 16, 2023 23:13
1a65bcf
to
b5b4630
Compare
PhilippHeuer
force-pushed
the
feature/micrometer
branch
from
February 28, 2023 20:14
c57d4c9
to
ea312b2
Compare
iProdigy
reviewed
Mar 2, 2023
Co-authored-by: iProdigy <8106344+iProdigy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites for Code Changes
Description
micrometer is a facade for metric collection, the goal is to provide metrics from all t4j components in a agnostic / easy way to improve observability.
Changes Proposed
Out-of-Scope
Additional Information
Can use the following when testing locally to print collected metrics every 10s:
MeterRegistry meterRegistry = new CompositeMeterRegistry(Clock.SYSTEM, Collections.singletonList(new LogMetricsRegistry()));
Chat
PubSub
Connection Pools