Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: populate SentChatMessage#isSent #967

Merged
merged 2 commits into from May 7, 2024
Merged

fix: populate SentChatMessage#isSent #967

merged 2 commits into from May 7, 2024

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Apr 8, 2024

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • SentChatMessage#isSent was false, even for successful requests

Changes Proposed

  • Properly deserialize is_sent property in SentChatMessage

Additional Information

Not critical since dropReason == null conveys the same information

@iProdigy iProdigy merged commit 7e4d7a8 into develop May 7, 2024
@iProdigy iProdigy deleted the fix/helix-chat-isSent-deser branch May 7, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer