Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(eventsub): change superclass for shield mode events #976

Merged
merged 2 commits into from May 4, 2024
Merged

refactor(eventsub): change superclass for shield mode events #976

merged 2 commits into from May 4, 2024

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Changes Proposed

  • Switch ShieldModeBeginEvent/ShieldModeEndEvent superclass to EventSubModeratorEvent

Additional Information

EventSub shield mode events have moderator_id but not user_id, so EventSubModerationEvent has extraneous fields for this topic

@iProdigy iProdigy merged commit b6eaa98 into develop May 4, 2024
@iProdigy iProdigy deleted the refactor/eventsub-shield-event-super-class branch May 4, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer PhilippHeuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iProdigy @PhilippHeuer