Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(helix): clarify Stream thumbnail url getters #977

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

refactor(helix): clarify Stream thumbnail url getters #977

wants to merge 3 commits into from

Conversation

iProdigy
Copy link
Member

Prerequisites for Code Changes

  • This pull request follows the code style of the project
  • I have tested this feature

Issues Fixed

  • Newcomers tend to assume Stream#getThumbnailUrl already yields a valid thumbnail (when they should be using Stream#getThumbnailUrl(Integer, Integer) instead)

Changes Proposed

  • Add Stream#getThumbnailUrlTemplate and deprecate Stream#getThumbnailUrl
  • Optimize getThumbnailUrl(int, int) by avoiding regex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippHeuer PhilippHeuer Awaiting requested review from PhilippHeuer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@iProdigy