Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean translation #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Korean translation #82

wants to merge 2 commits into from

Conversation

coma333Dev
Copy link

First Work

index.html translate by Korean

ko create
index.html korean translation
@@ -11,7 +11,7 @@
<!-- Example row of columns -->
<div class="row">
<div class="span8">
<p><b>Other Languages:</b> <a href="ru/index.html">Русский</a></p>
<p><b>Other Languages:</b> <a href="ru/index.html">Русский</a> &nbsp <a href="ko/index.html">한국어</a></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken HTTP entity. Perhaps it'd just better remove it? (i.e. s/&nbsp //)

@trustin
Copy link
Contributor

trustin commented Mar 19, 2013

All in all, this translation needs quite a bit of fixes. Although we can't always expect the quality of professional translator, we have to at least make sure the translation is correct enough. Please correct them, @coma333Dev.

One option I can think of is to leave the translation completely up to the community volunteers but to ensure that we have a notice at the top of the document that it's not from Twitter itself but from the community and we don't guarantee the quality or correctness of the translation.

Another food for thought is how we can allow community contributors to update the translation without granting too much permissions. Any idea?

@lahosken
Copy link
Contributor

a notice at the top of the document that it's not from Twitter itself but from the community and
we don't guarantee the quality or correctness of the translation.

With goofballs like me touching the English docs, we don't want to guarantee the quality of those either :-) That said, a notice at the top sounds good. Maybe something in [Korean | Russian | etc ] saying that translations are done by wonderful volunteers and that we welcome corrections.

how we can allow community contributors to update the translation

So far, translation-contributions are rare, so having Twitter employees handle pull requests doesn't seem like a hardship. If we get too many translation-contributions in the future, we might ask volunteers to check each others' work. E.g., if we get another Korean translation, we might ask the contributor to ask @coma333Dev to look at it. When @coma333Dev and the new contributor agree on a change, a Twitter person could merge.

@trustin
Copy link
Contributor

trustin commented Apr 2, 2013

@lahosken Agreed.

@coma333Dev Just in case it wasn't clear enough, the comments are not to scare you away. It will be awesome if you continue the translation, update this pull request, and go through the review process so that we end up with top-notch Korean translation.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants