chore: Reduce use of fmt.Sprintf

internal/chezmoi/archive.go

@@ -42,7 +42,7 @@ func (e UnknownArchiveFormatError) Error() string {
 	if e == UnknownArchiveFormatError(ArchiveFormatUnknown) {
 		return "unknown archive format"
 	}
-	return fmt.Sprintf("%s: unknown archive format", string(e))
+	return string(e) + ": unknown archive format"
 }
 
 // An WalkArchiveFunc is called once for each entry in an archive.

internal/cmd/addcmd.go

@@ -96,7 +96,7 @@ func (c *Config) defaultPreAddFunc(targetRelPath chezmoi.RelPath) error {
 		case choice == "yes":
 			return nil
 		default:
-			panic(fmt.Sprintf("%s: unexpected choice", choice))
+			panic(choice + ": unexpected choice")
 		}
 	}
 }
@@ -147,7 +147,7 @@ func (c *Config) defaultReplaceFunc(
 		case choice == "yes":
 			return nil
 		default:
-			panic(fmt.Sprintf("%s: unexpected choice", choice))
+			panic(choice + ": unexpected choice")
 		}
 	}
 }

internal/cmd/azurekeyvaulttemplatefuncs.go

@@ -2,6 +2,7 @@ package cmd
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/Azure/azure-sdk-for-go/sdk/azidentity"
@@ -72,7 +73,7 @@ func (c *Config) azureKeyVaultTemplateFunc(args ...string) string {
 	switch len(args) {
 	case 1:
 		if c.AzureKeyVault.DefaultVault == "" {
-			panic(fmt.Errorf("no value set in azureKeyVault.defaultVault"))
+			panic(errors.New("no value set in azureKeyVault.defaultVault"))
 		}
 		secretName, vaultName = args[0], c.AzureKeyVault.DefaultVault
 	case 2:

internal/cmd/cmd.go

@@ -252,7 +252,7 @@ func markPersistentFlagsRequired(cmd *cobra.Command, flags ...string) {
 func mustLongHelp(command string) string {
 	help, ok := helps[command]
 	if !ok {
-		panic(fmt.Sprintf("missing long help for command %s", command))
+		panic(command + ": missing long help")
 	}
 	return help.longHelp
 }

internal/cmd/config.go

@@ -526,7 +526,7 @@ func (c *Config) Close() error {
 // same key.
 func (c *Config) addTemplateFunc(key string, value any) {
 	if _, ok := c.templateFuncs[key]; ok {
-		panic(fmt.Sprintf("%s: already defined", key))
+		panic(key + ": already defined")
 	}
 	c.templateFuncs[key] = value
 }
@@ -981,7 +981,7 @@ func (c *Config) defaultPreApplyFunc(
 			case choice == "quit":
 				return chezmoi.ExitCodeError(0)
 			default:
-				panic(fmt.Sprintf("%s: unexpected choice", choice))
+				panic(choice + ": unexpected choice")
 			}
 		}
 	}
@@ -1023,7 +1023,7 @@ func (c *Config) defaultPreApplyFunc(
 		case choice == "quit":
 			return chezmoi.ExitCodeError(0)
 		default:
-			panic(fmt.Sprintf("%s: unexpected choice", choice))
+			panic(choice + ": unexpected choice")
 		}
 	}
 }

internal/cmd/doctorcmd.go

@@ -465,7 +465,7 @@ func (c *binaryCheck) Run(system chezmoi.System, homeDirAbsPath chezmoi.AbsPath)
 	var pathAbsPath chezmoi.AbsPath
 	switch path, err := chezmoi.LookPath(c.binaryname); {
 	case errors.Is(err, exec.ErrNotFound):
-		return c.ifNotExist, fmt.Sprintf("%s not found in $PATH", c.binaryname)
+		return c.ifNotExist, c.binaryname + " not found in $PATH"
 	case err != nil:
 		return checkResultFailed, err.Error()
 	default:
@@ -551,7 +551,7 @@ func (c *configFileCheck) Run(system chezmoi.System, homeDirAbsPath chezmoi.AbsP
 			filenameStrs = append(filenameStrs, filenameAbsPath.String())
 		}
 		sort.Strings(filenameStrs)
-		return checkResultWarning, fmt.Sprintf("%s: multiple config files", englishList(filenameStrs))
+		return checkResultWarning, englishList(filenameStrs) + ": multiple config files"
 	}
 }
 

internal/cmd/readdcmd.go

@@ -140,7 +140,7 @@ TARGET_REL_PATH:
 				case choice == "quit":
 					return chezmoi.ExitCodeError(0)
 				default:
-					panic(fmt.Sprintf("%s: unexpected choice", choice))
+					panic(choice + ": unexpected choice")
 				}
 			}
 		}

internal/cmd/statuscmd.go

@@ -1,6 +1,7 @@
 package cmd
 
 import (
+	"errors"
 	"fmt"
 	"io/fs"
 	"strings"
@@ -81,9 +82,9 @@ func (c *Config) runStatusCmd(cmd *cobra.Command, args []string) error {
 			case chezmoi.PathStyleRelative:
 				path = targetRelPath.String()
 			case chezmoi.PathStyleSourceAbsolute:
-				return fmt.Errorf("source-absolute not supported for status")
+				return errors.New("source-absolute not supported for status")
 			case chezmoi.PathStyleSourceRelative:
-				return fmt.Errorf("source-relative not supported for status")
+				return errors.New("source-relative not supported for status")
 			}
 
 			fmt.Fprintf(&builder, "%c%c %s\n", x, y, path)

internal/cmds/execute-template/main.go

@@ -93,7 +93,7 @@ func run() error {
 	}
 
 	if flag.NArg() == 0 {
-		return fmt.Errorf("no arguments")
+		return errors.New("no arguments")
 	}
 
 	templateName := path.Base(flag.Arg(0))

internal/git/status.go

@@ -3,7 +3,6 @@ package git
 import (
 	"bufio"
 	"bytes"
-	"fmt"
 	"regexp"
 	"strconv"
 )
@@ -127,7 +126,7 @@ var (
 )
 
 func (e ParseError) Error() string {
-	return fmt.Sprintf("%s: parse error", string(e))
+	return string(e) + ": parse error"
 }
 
 // ParseStatusPorcelainV2 parses the output of