Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add webpack-cli & remove deprecated uglify plugin #2844

Merged
merged 2 commits into from May 8, 2024
Merged

fix: add webpack-cli & remove deprecated uglify plugin #2844

merged 2 commits into from May 8, 2024

Conversation

Aylie-Chou
Copy link
Contributor

@Aylie-Chou Aylie-Chou commented May 8, 2024 •
edited

Issue

fix webpack build fail (log)

Notice

  • webpack-cli has separated from webpack after webpack v4 (ref)
  • replace uglify plugin with optamize.minimize (ref)
  • replace react-helmet with react-helmet-async (ref)

Dependency

N/A

@Aylie-Chou Aylie-Chou requested a review from liruchen32 May 8, 2024 16:31
@Aylie-Chou Aylie-Chou self-assigned this May 8, 2024
liruchen32
liruchen32 approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@liruchen32 liruchen32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aylie-Chou Aylie-Chou merged commit a865646 into twreporter:master May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liruchen32 liruchen32 liruchen32 approved these changes

Assignees

@Aylie-Chou Aylie-Chou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aylie-Chou @liruchen32